Skip to content

[PAY 8/19] Fix how validation displays in UI #2934

Closed

Description

@Beamanator

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Front-end validation should catch obviously invalid phone numbers, and display the error message "Please enter a phone number including the country code e.g +447814266907" instead of a clickable OptionRow. Like this:

Screen Shot 2021-05-14 at 8 52 39 PM

Actual Result:

No visual feedback given to user when OptionRow with invalid phone number is clicked, only an error is shown in the console:

Screen Shot 2021-05-14 at 8 49 09 PM

Action Performed:

  1. Click search icon
  2. Enter an invalid phone number (example: 7777)
  3. Click on the OptionRow that shows up:

Screen Shot 2021-05-14 at 8 47 49 PM

Workaround:

No workaround (other than making sure you enter valid phone numbers), but not a deploy-blocking issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.46.0
Notes/Photos/Videos:
Enhancements that can we worked on concurrently by the assigned engineer of this issue or worked on a week after this closes by someone else #2936

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/159892

View all open jobs on Upwork

Activity

  1. MelvinBot commented on May 14, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on May 14, 2021
  3. changed the title [-]Debounce account & fix validation on search, new chat, and related pages[/-] [+]Debounce account search typing & fix how validation displays in UI[/+] on May 14, 2021
  4. MelvinBot commented on May 14, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. Beamanator commented on May 14, 2021

    @Beamanator
    ContributorAuthor

    Unassigning @alexpensify , I don't believe triage is needed :D

  6. added
    ImprovementItem broken or needs improvement.
    and removed on May 14, 2021
  7. 59 remaining items

  8. Beamanator commented on Aug 13, 2021

    @Beamanator
    ContributorAuthor

    Wrong button 😅 glad we're on the same page now @Santhosh-Sellavel , sorry for the confusion 👍

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 17, 2021
  10. changed the title [-][PAY 8/19] Fix how validation displays in UI[/-] [+][HOLD for payment 2021-08-24] [PAY 8/19] Fix how validation displays in UI[/+] on Aug 17, 2021
  11. rdjuric commented on Aug 18, 2021

    @rdjuric
    Contributor

    Hi @mallenexpensify! Is there any job in Upwork for this issue? I wasn't hired yet and can't find one

  12. mallenexpensify commented on Aug 18, 2021

    @mallenexpensify
    Contributor

    @rdjuric lotta action in here, let's assume I messed something up.

    1. The most recent job post is here https://www.upwork.com/jobs/~018f3274b947f5d7b2
    2. Is this you? If so, confirm and I'll hire
      image
  13. changed the title [-][HOLD for payment 2021-08-24] [PAY 8/19] Fix how validation displays in UI[/-] [+][PAY 8/19] Fix how validation displays in UI[/+] on Aug 18, 2021
  14. rdjuric commented on Aug 19, 2021

    @rdjuric
    Contributor

    @mallenexpensify That's me! Thanks.

  15. mallenexpensify commented on Aug 19, 2021

    @mallenexpensify
    Contributor

    Hired @rdjuric in Upwork!

  16. mallenexpensify commented on Aug 20, 2021

    @mallenexpensify
    Contributor

    Paid in Upwork!

  17. Beamanator commented on Aug 20, 2021

    @Beamanator
    ContributorAuthor

    Great! Looks like it's time to close this out :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions