You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAY 8/19] Fix how validation displays in UI #2934
Front-end validation should catch obviously invalid phone numbers, and display the error message "Please enter a phone number including the country code e.g +447814266907" instead of a clickable OptionRow. Like this:
Actual Result:
No visual feedback given to user when OptionRow with invalid phone number is clicked, only an error is shown in the console:
Action Performed:
Click search icon
Enter an invalid phone number (example: 7777)
Click on the OptionRow that shows up:
Workaround:
No workaround (other than making sure you enter valid phone numbers), but not a deploy-blocking issue.
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.46.0 Notes/Photos/Videos:
Enhancements that can we worked on concurrently by the assigned engineer of this issue or worked on a week after this closes by someone else #2936
changed the title [-]Debounce account & fix validation on search, new chat, and related pages[/-][+]Debounce account search typing & fix how validation displays in UI[/+]on May 14, 2021
changed the title [-][PAY 8/19] Fix how validation displays in UI[/-][+][HOLD for payment 2021-08-24] [PAY 8/19] Fix how validation displays in UI[/+]on Aug 17, 2021
changed the title [-][HOLD for payment 2021-08-24] [PAY 8/19] Fix how validation displays in UI[/-][+][PAY 8/19] Fix how validation displays in UI[/+]on Aug 18, 2021
Activity
MelvinBot commentedon May 14, 2021
Triggered auto assignment to @alexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.[-]Debounce account & fix validation on search, new chat, and related pages[/-][+]Debounce account search typing & fix how validation displays in UI[/+]MelvinBot commentedon May 14, 2021
Triggered auto assignment to @mallenexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.Beamanator commentedon May 14, 2021
Unassigning @alexpensify , I don't believe triage is needed :D
59 remaining items
Beamanator commentedon Aug 13, 2021
Wrong button 😅 glad we're on the same page now @Santhosh-Sellavel , sorry for the confusion 👍
[-][PAY 8/19] Fix how validation displays in UI[/-][+][HOLD for payment 2021-08-24] [PAY 8/19] Fix how validation displays in UI[/+]rdjuric commentedon Aug 18, 2021
Hi @mallenexpensify! Is there any job in Upwork for this issue? I wasn't hired yet and can't find one
mallenexpensify commentedon Aug 18, 2021
@rdjuric lotta action in here, let's assume I messed something up.
[-][HOLD for payment 2021-08-24] [PAY 8/19] Fix how validation displays in UI[/-][+][PAY 8/19] Fix how validation displays in UI[/+]rdjuric commentedon Aug 19, 2021
@mallenexpensify That's me! Thanks.
mallenexpensify commentedon Aug 19, 2021
Hired @rdjuric in Upwork!
mallenexpensify commentedon Aug 20, 2021
Paid in Upwork!
Beamanator commentedon Aug 20, 2021
Great! Looks like it's time to close this out :D