You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD #2934] Enhancements for "Debounce account search typing & fix how validation displays in UI" #2936
On hold for #2934 since that one adds a necessary fix to phone number validation, and this one builds on that
These are enhancements are related to #2934. Please review that job for more details
Whomever is assigned that issue can work on these concurrently or after 2934 is fixed. If the assigner of 2934 doesn't want to work on this issue then it's held for anyone else until a week after 2934 is closed (to ensure there aren't regressions)
Enhancements:
When entering an email address or phone number in OptionsSelector's TextInputWithFocuStyles (on all screens where this exists), the app should do a few things:
Show a spinner when user is typing (debounce input, so stop showing spinner 300ms after user stops typing and do validation checks below)
When user has stopped typing for 300ms, do basic front-end validation checks
Email validation looks decent for now (Str.isValidEmai and !Str.isDomainEmail)
Phone number validation should get more strict, it's super basic at the moment (see Str.isValidPhone)
If above validation passes, do API-level validation for phone numbers only
Call the new Expensify API command IsValidPhoneNumber, which validates phone numbers in this format: '(\+?\d{10,15}|\d\d\d-\d\d\d-\d\d\d\d)'.
Make sure validation error messages still show correctly
If phone number is invalid, show error message "Please enter a phone number including the country code e.g +447814266907". Example:
If email address is invalid, show "Please enter a valid email address". Examples:
changed the title [-]Enhancements for "Debounce account search typing & fix how validation displays in UI"[/-][+][HOLD for #2934] Enhancements for "Debounce account search typing & fix how validation displays in UI"[/+]on Jul 30, 2021
changed the title [-][HOLD for #2934] Enhancements for "Debounce account search typing & fix how validation displays in UI"[/-][+][HOLD #2934] Enhancements for "Debounce account search typing & fix how validation displays in UI"[/+]on Jul 30, 2021
Activity
MelvinBot commentedon May 14, 2021
Triggered auto assignment to @mateocole (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon May 17, 2021
Triggered auto assignment to @thienlnam (
Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.54 remaining items
[-]Enhancements for "Debounce account search typing & fix how validation displays in UI"[/-][+][HOLD for #2934] Enhancements for "Debounce account search typing & fix how validation displays in UI"[/+][-][HOLD for #2934] Enhancements for "Debounce account search typing & fix how validation displays in UI"[/-][+][HOLD #2934] Enhancements for "Debounce account search typing & fix how validation displays in UI"[/+]Beamanator commentedon Aug 9, 2021
Issue we're holding for hasn't been completely fixed yet
Beamanator commentedon Aug 16, 2021
Back to weekly since I'm focusing on some other tasks for now
Beamanator commentedon Aug 17, 2021
Closing this issue since it would be nice to have a fresh start when we're ready
mallenexpensify commentedon Oct 15, 2021
Canceled job in Upwork