Skip to content

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Click the + action button and request money
  2. Select Scan
  3. Upload receipt as part of the Scan flow and complete the process
  4. Open the uploaded receipt

Expected Result:

Smart scanning header is visible

Actual Result:

Smart scanning header is broken

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6237271_1697310012718.Recording__4999.mp4
MacOS: Desktop

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 14, 2023
  2. melvin-bot commented on Oct 14, 2023

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Oct 14, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Oct 14, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 14, 2023

    @melvin-bot

    Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. abdel-h66 commented on Oct 14, 2023

    @abdel-h66
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Split details receipt scan header is broken

    What is the root cause of that problem?

    In the SplitDetailsPage.js <MoneyRequestHeaderStatusBar is called without any arguments

    {isScanning && <MoneyRequestHeaderStatusBar />}

    What changes do you think we should make in order to solve the problem?

    Update the SplitDetailsPage.js to call with the required arguments <MoneyRequestHeaderStatusBar /> similar to what's being done in MoneyRequestHeader.js

                        {isScanning && <MoneyRequestHeaderStatusBar 
                         title={translate('iou.receiptStatusTitle')}
                         description={translate('iou.receiptStatusText')}
                         shouldShowBorderBottom
                        />}

    What alternative solutions did you explore? (Optional)

    N/A

  7. shubham1206agra commented on Oct 15, 2023

    @shubham1206agra
    Contributor

    Offending PR #29201

  8. mountiny commented on Oct 15, 2023

    @mountiny
    Contributor
  9. 38 remaining items

  10. joekaufmanexpensify commented on Oct 23, 2023

    @joekaufmanexpensify
    Contributor

    I see @rushatgabhane was actually already paid for this one on the PR.

  11. joekaufmanexpensify commented on Oct 23, 2023

    @joekaufmanexpensify
    Contributor

    @rushatgabhane please complete your portion of the BZ checklist when you have a sec, and then we'll be all set to close this out!

  12. joekaufmanexpensify commented on Oct 24, 2023

    @joekaufmanexpensify
    Contributor

    Pending completion of checklist

  13. joekaufmanexpensify commented on Oct 25, 2023

    @joekaufmanexpensify
    Contributor
  14. joekaufmanexpensify commented on Oct 26, 2023

    @joekaufmanexpensify
    Contributor

    Still pending completion

  15. melvin-bot commented on Oct 30, 2023

    @melvin-bot

    @rushatgabhane, @thienlnam, @grgia, @joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. joekaufmanexpensify commented on Oct 30, 2023

    @joekaufmanexpensify
    Contributor

    Not overdue. @rushatgabhane is anything needed for BZ checklist here?

  17. joekaufmanexpensify commented on Oct 31, 2023

    @joekaufmanexpensify
    Contributor

    Bumped in Slack

  18. joekaufmanexpensify commented on Nov 1, 2023

    @joekaufmanexpensify
    Contributor

    Still pending input

  19. rushatgabhane commented on Nov 2, 2023

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201 (comment)

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

    4. Determine if we should create a regression test for this bug. Sure

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

      1. Create a money request -> upload receipt -> click on Money Request Preview
      2. Verify "Scanning" Banner is shown
  20. rushatgabhane commented on Nov 2, 2023

    @rushatgabhane
    Member

    we can close the issue

  21. joekaufmanexpensify commented on Nov 3, 2023

    @joekaufmanexpensify
    Contributor

    Sweet, TY! BZ checklist is all set. Payment was already issued on the PR, so closing as this one is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions