You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Split details receipt scan header is broken
What is the root cause of that problem?
In the SplitDetailsPage.js <MoneyRequestHeaderStatusBar is called without any arguments
{isScanning&&<MoneyRequestHeaderStatusBar/>}
What changes do you think we should make in order to solve the problem?
Update the SplitDetailsPage.js to call with the required arguments <MoneyRequestHeaderStatusBar /> similar to what's being done in MoneyRequestHeader.js
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Sure
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
Create a money request -> upload receipt -> click on Money Request Preview
Activity
melvin-bot commentedon Oct 14, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 14, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Oct 14, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 14, 2023
Triggered auto assignment to @thienlnam (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.abdel-h66 commentedon Oct 14, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Split details receipt scan header is broken
What is the root cause of that problem?
In the SplitDetailsPage.js <MoneyRequestHeaderStatusBar is called without any arguments
What changes do you think we should make in order to solve the problem?
Update the SplitDetailsPage.js to call with the required arguments
<MoneyRequestHeaderStatusBar />similar to what's being done inMoneyRequestHeader.jsWhat alternative solutions did you explore? (Optional)
N/A
shubham1206agra commentedon Oct 15, 2023
Offending PR #29201
mountiny commentedon Oct 15, 2023
cc @grgia
38 remaining items
joekaufmanexpensify commentedon Oct 23, 2023
I see @rushatgabhane was actually already paid for this one on the PR.
joekaufmanexpensify commentedon Oct 23, 2023
@rushatgabhane please complete your portion of the BZ checklist when you have a sec, and then we'll be all set to close this out!
joekaufmanexpensify commentedon Oct 24, 2023
Pending completion of checklist
joekaufmanexpensify commentedon Oct 25, 2023
Bumped in Slack
joekaufmanexpensify commentedon Oct 26, 2023
Still pending completion
melvin-bot commentedon Oct 30, 2023
@rushatgabhane, @thienlnam, @grgia, @joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
joekaufmanexpensify commentedon Oct 30, 2023
Not overdue. @rushatgabhane is anything needed for BZ checklist here?
joekaufmanexpensify commentedon Oct 31, 2023
Bumped in Slack
joekaufmanexpensify commentedon Nov 1, 2023
Still pending input
rushatgabhane commentedon Nov 2, 2023
The PR that introduced the bug has been identified. Link to the PR: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Sure
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
rushatgabhane commentedon Nov 2, 2023
we can close the issue
joekaufmanexpensify commentedon Nov 3, 2023
Sweet, TY! BZ checklist is all set. Payment was already issued on the PR, so closing as this one is good to go.