Repository navigation
[CP Staging] - Only show Pending Banner for ECard Transactions - #29659
Conversation
Deploying with
|
| Latest commit: |
1d34ee5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56bf5c5a.helpdot.pages.dev |
| Branch Preview URL: | https://georgia-fixsmartscanbanner.helpdot.pages.dev |
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
does this need my review? |
|
@rushatgabhane yes, if you could review that would be great. I'm working on screenshots but need to rebuild VM |
Reviewer Checklist
Screenshots/VideosDesktopSkipping this one |
|
@rushatgabhane I merged main since one bug was already fixed |
|
@rushatgabhane I pushed a solution, thanks! |
|
testing! |
|
|
||
| const isScanning = TransactionUtils.hasReceipt(transaction) && TransactionUtils.isReceiptBeingScanned(transaction); | ||
| const isPending = TransactionUtils.isPending(transaction); | ||
| const isPending = TransactionUtils.isExpensifyCardTransaction(transaction) && TransactionUtils.isPending(transaction); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
It looks like your transactionID was incorrect, I don't see the amount set in this example
There was a problem hiding this comment.
oh good catch, thank you! 🙇
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mountiny
left a comment
There was a problem hiding this comment.
Thanks for a quick resolution ❤️
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] - Only show Pending Banner for ECard Transactions (cherry picked from commit 5a5b890)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.84-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.86-0 🚀
|
|
@JmillsExpensify |
|
$500 payment approved for @rushatgabhane based on summary above. |
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀
|












Details
It seems like some non ECard transactions are getting the transaction.status key set to "Pending". For now, let's ensure that only ECard transactions will show the Pending UI.
Fixed Issues
$ #29625
$ #29626
Tests / QA Steps
Test Scan Receipt Flow
Screen.Recording.2023-10-16.at.9.22.02.AM.mov
Test Split Scan Receipt Flow
Test ECard Transaction Pending Shows
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop