Skip to content

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as Pending #29625

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697243512619269

Action Performed:

  1. Next to the compose box, click the + action button and request money
  2. Upload receipt as part of the Scan flow
  3. Notice Pending shows at top, during SmartScan process and after it's done SmartScanning

Expected Result:

Pending to not show

Actual Result:

When uploading a receipt via the request money flow, it shows as Pending

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
bandicam.2023-10-15.02-28-34-840.mp4

image (6) (1)

View all open jobs on GitHub

Activity

  1. OSBotify commented on Oct 14, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Oct 14, 2023

    @melvin-bot

    Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. abdel-h66 commented on Oct 14, 2023

    @abdel-h66
    Contributor

    It seems to be a normal behavior, the pending will disappear as stated in the message. this new behavior was added here
    #29201

  4. self-assigned this
    on Oct 16, 2023
  5. mountiny commented on Oct 16, 2023

    @mountiny
    Contributor
    image

    also fixed

    Payment for c+ handled here #29626 closing

  6. 1 remaining item

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 16, 2023
  8. changed the title [-]Desktop - When uploading a receipt via the request money flow, it shows as `Pending`[/-] [+][HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as `Pending`[/+] on Oct 16, 2023
  9. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. changed the title [-][HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as `Pending`[/-] [+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as `Pending`[/+] on Oct 16, 2023
  12. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as `Pending`[/-] [+][HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as `Pending`[/+] on Oct 17, 2023
  14. melvin-bot commented on Oct 17, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-24. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions