Skip to content

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

Description

@OSBotify

Release Version: 1.3.86-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. francoisl commented on Oct 17, 2023

    @francoisl
    Contributor

    Going to clean up the dupes again 😒

    Details
    https://github.com/Expensify/App/pull/24528
    https://github.com/Expensify/App/pull/26862
    https://github.com/Expensify/App/pull/27705
    https://github.com/Expensify/App/pull/27857
    https://github.com/Expensify/App/pull/28271
    https://github.com/Expensify/App/pull/28316
    https://github.com/Expensify/App/pull/28372
    https://github.com/Expensify/App/pull/28644
    https://github.com/Expensify/App/pull/28846
    https://github.com/Expensify/App/pull/28894
    https://github.com/Expensify/App/pull/28900
    https://github.com/Expensify/App/pull/28990
    https://github.com/Expensify/App/pull/29065
    https://github.com/Expensify/App/pull/29242
    https://github.com/Expensify/App/pull/29256
    https://github.com/Expensify/App/pull/29279
    https://github.com/Expensify/App/pull/29288
    https://github.com/Expensify/App/pull/29331
    https://github.com/Expensify/App/pull/29337
    https://github.com/Expensify/App/pull/29385
    https://github.com/Expensify/App/pull/29396
    https://github.com/Expensify/App/pull/29422
    https://github.com/Expensify/App/pull/29423
    https://github.com/Expensify/App/pull/29448
    https://github.com/Expensify/App/pull/29482
    https://github.com/Expensify/App/pull/29530
    https://github.com/Expensify/App/pull/29545
    https://github.com/Expensify/App/pull/29551
    https://github.com/Expensify/App/pull/29568
    https://github.com/Expensify/App/pull/29575
    https://github.com/Expensify/App/pull/29578
    https://github.com/Expensify/App/pull/29579
    https://github.com/Expensify/App/pull/29588
    https://github.com/Expensify/App/pull/29590
    https://github.com/Expensify/App/pull/29592
    https://github.com/Expensify/App/pull/29599
    https://github.com/Expensify/App/pull/29600
    https://github.com/Expensify/App/pull/29603
    https://github.com/Expensify/App/pull/29617
    https://github.com/Expensify/App/pull/29662
    https://github.com/Expensify/App/pull/29671
    
  2. kavimuru commented on Oct 18, 2023

    @kavimuru

    Checkigng off #29629, #29659, #29677, #29682 from past build

  3. OSBotify commented on Oct 18, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.86-0 🚀

  4. kavimuru commented on Oct 18, 2023

    @kavimuru

    @francoisl Regression is 67% progress. We are still validating couple PRs.
    #28364 failing with #29839
    #29420 failing with #27090 in Android and iOS
    #28984 failing with #29849

  5. kavimuru commented on Oct 18, 2023

    @kavimuru

    Regression is only 9% left.
    #28364 failing with #29839
    #29420 failing with #27090 in Android and iOS (Not fixed)
    #28984 failing with #29849

  6. francoisl commented on Oct 18, 2023

    @francoisl
    Contributor

    Thanks for the update. We're working on the remaining blockers.


    • 29877: checking off, blocker label removed
    • 29395 QA'ed internally, checking
    • 29849: checking off, blocker label removed
    • 29850: tested internally, checking
    • 29855: tested internally, checking
    • 29884: explained as not an issue, removing blocker label
    • 29853: edge case not worth blocking for
    • 29839: fix tested on staging, checking off
    • 29889: fix tested on staging, checking 29062
  7. self-assigned this
    on Oct 18, 2023
  8. francoisl commented on Oct 18, 2023

    @francoisl
    Contributor

    We're down to 1 blocker, a fix is being CP'ed right now. I'll test it when it's finished and close this if everything is good.

  9. kavimuru commented on Oct 18, 2023

    @kavimuru

    #29844 is failing with blocker #29918

  10. francoisl commented on Oct 18, 2023

    @francoisl
    Contributor

    Going to remove the blocker label #29918 as explained here, reverting the PR that caused it would reintroduce another crash. It's also seemingly fixed on main already, and it's also still possible to delete messages by clicking the trash icon.

  11. francoisl commented on Oct 18, 2023

    @francoisl
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions