Skip to content

Revert "webfix/27090 In Header Workspace, members are not shown." - #29833

Merged
deetergp merged 1 commit into
mainfrom
revert-29420-webfix/27090-iou-header-workspace
Oct 17, 2023
Merged

deetergp merged 1 commit into
mainfrom
revert-29420-webfix/27090-iou-header-workspace

Conversation

@jasperhuangg

@jasperhuangg jasperhuangg commented Oct 17, 2023 •

Copy link
Copy Markdown
Contributor

Reverts #29420

We need to revert this PR because the issue that it fixes isn't actually a bug. We don't share workspace rooms by default with everyone in the workspace on creation, so it's expected that workspace rooms only have a single participant by default.

@jasperhuangg
jasperhuangg requested a review from deetergp October 17, 2023 21:28
@jasperhuangg
jasperhuangg requested a review from a team as a code owner October 17, 2023 21:28
@melvin-bot
melvin-bot Bot removed the request for review from a team October 17, 2023 21:28
@melvin-bot

melvin-bot Bot commented Oct 17, 2023

Copy link
Copy Markdown

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg jasperhuangg self-assigned this Oct 17, 2023
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 351c98a
Status: ✅  Deploy successful!
Preview URL: https://b5aa31b5.helpdot.pages.dev
Branch Preview URL: https://revert-29420-webfix-27090-io.helpdot.pages.dev

View logs

@deetergp
deetergp merged commit d0ab966 into main Oct 17, 2023
@deetergp
deetergp deleted the revert-29420-webfix/27090-iou-header-workspace branch October 17, 2023 21:32
@melvin-bot melvin-bot Bot added the Emergency label Oct 17, 2023
@melvin-bot

melvin-bot Bot commented Oct 17, 2023

Copy link
Copy Markdown

@deetergp looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.86-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants