Repository navigation
[No QA][TS migration] Migrate 'Timing.js' lib to TypeScript - #27705
Conversation
|
Reviewer checklist updated. |
jjcoffee
left a comment
There was a problem hiding this comment.
I have not reviewed this.
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24874 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
Same situtation as this issue |
|
@fvlvte bump |
790d50b to
cb4a523
Compare
|
Sorry @BartoszGrajdek - had some issues with recording these vids, updated PR with videos & resolved conflict with main. |
|
Reviewing... |
|
LGTM! |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromechrome.movMobile Web - Safarisafari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
|
Is my review needed here, since @BartoszGrajdek has already completed the checklist? |
|
@jjcoffee I was told to ask You for review so I guess yes :P |
|
Ah I think it's because the process has since changed, but since @BartoszGrajdek gave their review and completed the checklist before that I imagine I'm not needed here. Will double check on Slack! |
jjcoffee
left a comment
There was a problem hiding this comment.
I have not reviewed this.
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24874 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
Lint is failing @fvlvte |
|
@youssef-lr resolved |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.85-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀
|
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.86-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀
|

Details
Migrated src/libs/actions/Timing.js to TypeScript.
Fixed Issues
$ #24874
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web-ff.mov
Mobile Web - Chrome
web-chrome.mov
Mobile Web - Safari
web-safari.mov
Desktop
electron.mov
iOS
ios-17.mov
Android
android.mov