You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Split - Contact method of the participants is shown in Merchant instead of display name #29858
Version Number: v1.3.86-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Go to staging.new.expensify.com
Go to + > Request money > Manual.
Select Split with a few participants with display name.
Create the bill split.
Click on the bill split preview > Show more.
Expected Result:
Display name of the participants will be displayed in the Merchant.
Actual Result:
Contact method of the participants is displayed in the Merchant.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Split - Contact method of the participants is shown in Merchant instead of display name[/-][+][$500] Split - Contact method of the participants is shown in Merchant instead of display name[/+]on Oct 18, 2023
What alternative solutions did you explore? (Optional)
We also need to ensure that if a user updates their display name from their profile, the transaction gets updated with the new display name. To achieve this, we should generate the formatted string as mentioned above before displaying the data OR update transactions merchant field as soon as user updates his or her profile, other than storing it in Onyx as follows:
@ntdiary@zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@situchan Yeah. Many thanks. But I have a minor question, In the link you mentioned, I just can access the #25885, and the issue mentioned in that does not appear anymore and does not relate to this issue.
Display name of the participants will be displayed in the Merchant.
I feel the expected behavior in the OP may not be what we want.
As I mentioned before, this is not so much a bug but rather a feature request, and likely one that would not get approved. 😂
So it's fine to just fix the merchant field saving problem.
@ntdiary My proposal also mentioned an issue that if user updates his account details then merchant field does not gets updated with his new email address or display name what ever we need to show there.
Activity
melvin-bot commentedon Oct 18, 2023
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Split - Contact method of the participants is shown in Merchant instead of display name[/-][+][$500] Split - Contact method of the participants is shown in Merchant instead of display name[/+]melvin-bot commentedon Oct 18, 2023
Job added to Upwork: https://www.upwork.com/jobs/~018d28ed12ed77a99a
melvin-bot commentedon Oct 18, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 18, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (
External)shubham1206agra commentedon Oct 18, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Split - Contact method of the participants is shown in Merchant instead of display name
What is the root cause of that problem?
In
App/src/libs/actions/IOU.js
Lines 910 to 912 in a24e6a0
We are using
participant.logininstead ofparticipant.text, which is displaying contact method.What changes do you think we should make in order to solve the problem?
Use
participant.textinstead ofparticipant.textin the given line.And maybe somehow use current user display name instead of currentUserLogin.
What alternative solutions did you explore? (Optional)
ayazalavi commentedon Oct 18, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
When adding a money request manually and selecting participants, the report details show the participants' email addresses in the merchant field.
What is the root cause of that problem?
Root cause is that when adding transaction for split bill then following line of code uses user's login for generating Bill Split with string.
App/src/libs/actions/IOU.js
Lines 910 to 912 in a24e6a0
What changes do you think we should make in order to solve the problem?
Use getDisplayName
so instead of
currentUserLoginwe need to usegetDisplayName(currentUserLogin, currentUserPersonalDetails)and instead of
participant.loginwe need to usegetDisplayName(participant.login, participant)What alternative solutions did you explore? (Optional)
We also need to ensure that if a user updates their display name from their profile, the transaction gets updated with the new display name. To achieve this, we should generate the formatted string as mentioned above before displaying the data OR update transactions merchant field as soon as user updates his or her profile, other than storing it in Onyx as follows:
App/src/libs/actions/IOU.js
Lines 914 to 927 in a24e6a0
zanyrenney commentedon Oct 20, 2023
Nope, this is not reproducible, I suspect it has been fixed elsewhere or is an older bug:

21 remaining items
DylanDylann commentedon Oct 31, 2023
@aimane-chnaif My proposal mention 3 related issue #29858 (comment) So should we need to fix each issue in separate PR or wrap these into one?
melvin-bot commentedon Nov 1, 2023
@ntdiary @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Nov 1, 2023
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
zanyrenney commentedon Nov 2, 2023
Hmm, I think this is a dupe of #29691
I see the comment above, but closing on these grounds.
DylanDylann commentedon Nov 2, 2023
@zanyrenney it's not a dupe. Please help check my proposal for more detail.
@ntdiary Can you help confirm.
situchan commentedon Nov 2, 2023
@DylanDylann please check #29858 (comment).
This will be handled internally.
cc: @youssef-lr
DylanDylann commentedon Nov 2, 2023
@situchan My proposal mentioned 3 related issues. What issue that you mentioned in "This will be handled internally"?
situchan commentedon Nov 2, 2023
@youssef-lr will decide as he's leading split bill project. Please hold on and wait for update.
DylanDylann commentedon Nov 2, 2023
@situchan Yeah. Many thanks. But I have a minor question, In the link you mentioned, I just can access the #25885, and the issue mentioned in that does not appear anymore and does not relate to this issue.
youssef-lr commentedon Nov 3, 2023
@DylanDylann this is getting fixed here #30721
ntdiary commentedon Nov 3, 2023
As I mentioned before, this is not so much a bug but rather a feature request, and likely one that would not get approved. 😂
So it's fine to just fix the merchant field saving problem.
ayazalavi commentedon Nov 3, 2023
@ntdiary My proposal also mentioned an issue that if user updates his account details then merchant field does not gets updated with his new email address or display name what ever we need to show there.