[Hold for Payment 1st June] IOU - Name is not visible in the IOU request page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Expected Result:

User's name should be visible in the request page.

Actual Result:

Username is not visible and there's a blank space

Action Performed:

Log in to e.cash with a expensifail account
Navigate to a conversation
Click on the + button
Click on request money
Set an amount
Click continue

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android ✔️
Desktop App
Mobile Web ✔️

Version Number: 1.0.48-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
I was unable to verify the issue in production due to the blank page issue #2969

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@arielgreen

Triggered auto assignment to @arielgreen (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

I'm unable to reproduce this in the request money flow on v.1.0.48-3:

I am however able to reproduce this in the split bill flow:

I'm seeing this for the Request Money flow too on version v1.0.48-3:

OptionRow has the correct name, but DisplayNames does not:

Strange. I re-added and changed my name in Expensify to see if there was anything in that, but nothing. Anyhow, let's get this to engineering and I'll add it the IOU parent issue as a regression to fix.

@Beamanator

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

10/10 can reproduce 😅

Looks like in the IOUConfirmationList component we don't pass showTitleTooltip to OptionRow, so tooltipEnabled is never passed as true to DisplayNames.

In DisplayNames, if this.props.tooltipEnabled is false (which it always will be for this page), we try to display this.props.fullTitle. It seems this.props.fullTitle is an empty string here, always. Which seems odd.

If we decide to pass showTitleTooltip as true in IOUConfirmationList, it would make it all the way to DisplayNames, and then we would try to render data from this.props.displayNamesWithTooltips, but this appears to be an empty array always. This also seems odd.

fullTitle is created from displayNamesWithTooltips, which is created from option.participantsList, which seems to be missing in the OptionRow -> this is probably where our issues are coming from.

Continuing investigation...

It seems a regression by #2724.

Issue not reproducible today during KI retests (First Week)

Hm yeah, odd. Same for me on v1.0.51-2:

Same - can't reproduce anymore.

I believe it was fixed here: 54a21d9#diff-0f2d048995be66cab42aa4bdf71f1befedeb2989e3bd00c8113fb54b98a54f76

Where this change was made in OptionRow.js:

-   const fullTitle = displayNamesWithTooltips.map(({displayName}) => displayName).join(', ');
+   const fullTitle = option.text ? option.text
+        : displayNamesWithTooltips.map(({displayName}) => displayName).join(', ');

@Beamanator

@Beamanator
Hi! This patch solves this problem but does not solve the firstiNames in the chat title
this pr is created to solve: #3027

Merge pull request #3027 from Viacheslav80/fix_IOU_name_is_not_visible

Thanks guys!

I think this can be closed now.

Yep! 👍

Navigation Menu

Repository navigation

[Hold for Payment 1st June] IOU - Name is not visible in the IOU request page #2996

Expected Result:

Actual Result:

Action Performed:

Workaround:

Platform:

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Hold for Payment 1st June] IOU - Name is not visible in the IOU request page #2996

Description

Expected Result:

Actual Result:

Action Performed:

Workaround:

Platform:

Activity

MelvinBot commented on May 19, 2021

trjExpensify commented on May 19, 2021

Julesssss commented on May 19, 2021

trjExpensify commented on May 19, 2021

MelvinBot commented on May 19, 2021

Beamanator commented on May 19, 2021

Beamanator commented on May 19, 2021

parasharrajat commented on May 19, 2021

13 remaining items

isagoico commented on May 23, 2021

trjExpensify commented on May 24, 2021

Beamanator commented on May 24, 2021

Viacheslav80 commented on May 24, 2021

trjExpensify commented on May 25, 2021

parasharrajat commented on Jul 22, 2021

trjExpensify commented on Jul 22, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions