Skip to content

IOU - Tax settings for Foreign Currency Default are not applied #34055

New issue
New issue
Closed
Closed
IOU - Tax settings for Foreign Currency Default are not applied#34055
Assignees
stitesExpensifyzanyrenney
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Description

@lanitochka17
lanitochka17
opened on Jan 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32550

Action Performed:

Preconditions:
In OldDot under admin, create a Collect group policy, enable categories and add 3 categories, add an employee to the policy.

  1. Open New Expensify app
  2. Log in to the employee's account
  3. Tap on the green plus button (FAB)
  4. Select Request money
  5. Select any currency and amount
  6. Click next
  7. Choose a group policy room
  8. Click on "Show more"
  9. In the category section, select the category at the bottom of the list
  10. Navigate to the categories section again

Expected Result:

When changing a currency other than the standard policy, the Tax Foreign Currency Default settings from OldDot should be automatically applied for the selected currency

Actual Result:

Tax settings for Foreign Currency Default are not applied

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333427_1704481015812.Recording__1031.mp4

View all open jobs on GitHub

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 5, 2024
  2. melvin-bot
    assigned
    zanyrenney
    on Jan 5, 2024

  3. melvin-bot commented on Jan 5, 2024

    @melvin-bot
    melvin-botBot
    on Jan 5, 2024 – with Melvin Bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot
    added
    DailyKSv2
    on Jan 5, 2024

  5. melvin-bot commented on Jan 5, 2024

    @melvin-bot
    melvin-botBot
    on Jan 5, 2024 – with Melvin Bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Jan 5, 2024

  7. github-actions commented on Jan 5, 2024

    @github-actions
    github-actionsBot
    on Jan 5, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. melvin-bot
    assigned
    stitesExpensify
    on Jan 5, 2024

  9. melvin-bot commented on Jan 5, 2024

    @melvin-bot
    melvin-botBot
    on Jan 5, 2024 – with Melvin Bot

    Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  10. melvin-bot commented on Jan 5, 2024

    @melvin-bot
    melvin-botBot
    on Jan 5, 2024 – with Melvin Bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. mvtglobally commented on Jan 7, 2024

    @mvtglobally
    mvtglobally
    on Jan 7, 2024

    Still repro on build 1.4.22-2

    bandicam.2024-01-06.14-18-59-455.mp4
  12. thienlnam
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Jan 8, 2024
  13. melvin-bot
    added
    Overdue
    on Jan 8, 2024

  14. thienlnam commented on Jan 8, 2024

    @thienlnam
    thienlnam
    on Jan 8, 2024
    Contributor

    Removing the blocker since I don't think we use this feature right now on NewDot - but something we should fix

  15. MonilBhavsar commented on Jan 9, 2024

    @MonilBhavsar
    MonilBhavsar
    on Jan 9, 2024
    Contributor

    Known and already planned in the wave issue and it is WIP https://github.com/Expensify/Expensify/issues/305057
    Not a bug

  16. MonilBhavsar
    closed this as completedon Jan 9, 2024
  17. melvin-bot
    removed
    Overdue
    on Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions