[$500] Start Chat - Workspace not auto selected when creating Room for public existing user #34519

Activity

1. lanitochka17

   added

   ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor

   DailyKSv2KSv2

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   on Jan 15, 2024
2. melvin-bot

   changed the title [-]Start Chat - Workspace not auto selected when creating Room for public existing user[/-] [+][$500] Start Chat - Workspace not auto selected when creating Room for public existing user[/+] on Jan 15, 2024
3. melvin-bot commented on Jan 15, 2024

   

   melvin-botBot

   on Jan 15, 2024 – with Melvin Bot

   More actions

   Job added to Upwork: https://www.upwork.com/jobs/~0153cb4ce8578165a7
4. melvin-bot

   assigned

   kadiealexander

   on Jan 15, 2024
5. melvin-bot commented on Jan 15, 2024

   

   melvin-botBot

   on Jan 15, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
6. melvin-bot

   added

   Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

   on Jan 15, 2024
7. melvin-bot

   assigned

   mananjadhav

   on Jan 15, 2024
8. melvin-bot commented on Jan 15, 2024

   

   melvin-botBot

   on Jan 15, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)
9. BhuvaneshPatil commented on Jan 15, 2024

   

   BhuvaneshPatil

   on Jan 15, 2024

   Last edited by BhuvaneshPatil

   Contributor

   More actions

   Proposal

   Please re-state the problem that we are trying to solve in this issue.

   Start Chat - Workspace not auto selected when creating Room for public existing user

   What is the root cause of that problem?

   we are not initialising any value for policyID in WorkspaceNewRoomPage. We are setting it as null.
   

   App/src/pages/workspace/WorkspaceNewRoomPage.js

   Line 103 in a4e3ae2

   const [policyID, setPolicyID] = useState(props.activePolicyID);

   What changes do you think we should make in order to solve the problem?

   1. Set the state initially like this

       const [policyID, setPolicyID] = useState(PolicyUtils.getActivePolicies(props.policies).at(0)?.id || null);

   Currently we are setting it as first policy, we can change to other index if required
   2. use that value in InputWrapper for policy

                                   <InputWrapper
                                       InputComponent={ValuePicker}
                                       inputID="policyID"
                                       label={translate('workspace.common.workspace')}
                                       items={workspaceOptions}
                                       onValueChange={setPolicyID}
                                       value={policyID}
                                   />

   What alternative solutions did you explore? (Optional)
10. abzokhattab commented on Jan 15, 2024

    

    abzokhattab

    on Jan 15, 2024

    Last edited by abzokhattab

    Contributor

    More actions

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace not auto selected when creating Room for public existing user

    What is the root cause of that problem?

    The backend doesn't return the account.activePolicyID https://github.com/Expensify/App/blob/a4e3ae2546882b0971ed80e6ce0fd4c6b85cf956/src/pages/workspace/WorkspaceNewRoomPage.js#L369C2-L373C11

    thats why the displays empty workspace

    What changes do you think we should make in order to solve the problem?

    either this issue is fixed in the backend,

    or we add a fallback to select the first workspace if the account.activePolicyID is not returned:

    if we go with this approach then we need to change this https://github.com/Expensify/App/blob/a4e3ae2546882b0971ed80e6ce0fd4c6b85cf956/src/pages/workspace/WorkspaceNewRoomPage.js#L103C5-L103C5

    to

        const [policyID, setPolicyID] = useState(props.activePolicyID ||  props.policies[0].id);

    we can of course use lodash to safely access those the props.policies object
11. dummy-1111 commented on Jan 15, 2024

    

    dummy-1111

    on Jan 15, 2024

    Contributor

    More actions

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace isn't auto selected in creating room page even when there are active workspaces

    What is the root cause of that problem?

    We have two code segments to initialize the workspace value
    

    App/src/pages/workspace/WorkspaceNewRoomPage.js

    Line 103 in a4e3ae2

    const [policyID, setPolicyID] = useState(props.activePolicyID);

    App/src/pages/workspace/WorkspaceNewRoomPage.js

    Lines 145 to 150 in a4e3ae2

    	useEffect(() => {
    	if (policyID) {
    	return;
    	}
    	setPolicyID(props.activePolicyID);
    	}, [props.activePolicyID, policyID]);

    The problem is the value of activePolicyID. There may be 2 cases

    • activePolicyID is empty
    • activePolicyID isn't included in active policies

    These cases were not handled. This is the root cause

    What changes do you think we should make in order to solve the problem?

    We need to handle the above 2 cases

    1. Move this code above this line
    2. Update the effect code as follows

        useEffect(() => {
            if (workspaceOptions.length === 0 || policyID && workspaceOptions.some(option => option.value === policyID)) {
                return;
            }
            if (props.activePolicyID && workspaceOptions.some(option => option.value === policyID)) {
                setPolicyID(props.activePolicyID);
            } else {
                setPolicyID(workspaceOptions[0].value);
            }
        }, [props.activePolicyID, policyID, workspaceOptions]);
    

    This works as expected

    Result

    34519.mp4

    What alternative solutions did you explore? (Optional)
12. DylanDylann commented on Jan 16, 2024

    

    DylanDylann

    on Jan 16, 2024

    Contributor

    More actions

    This feature is done here, It seems we need to wait a update from BE
    cc @alitoshmatov @s-alves10
13. melvin-bot

    added

    Overdue

    on Jan 17, 2024
14. kadiealexander commented on Jan 19, 2024

    

    kadiealexander

    on Jan 19, 2024

    Last edited by kadiealexander

    Contributor

    More actions

    Closing as a dupe of #32435
15. kadiealexander

    closed this as completedon Jan 19, 2024
16. melvin-bot

    removed

    Overdue

    on Jan 19, 2024