[HOLD for payment 2024-03-04] [$250] Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestCategoryPage
New Component IOURequestStepCategory

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01aa1b22b861ac0e42
Upwork Job ID: 1747632761920925696
Last Price Increase: 2024-01-24
Automatic offers:

DylanDylann | Contributor | 28129737
dukenv0307 | Contributor | 28130978

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

would love to work on this!

Please add a proposal for the changes that are necessary (I know I gave a brief overview, but your proposal should cover more details as I copy/pasted that into at least a dozen issues).

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js

What is the root cause of that problem?

Clean Up  of MoneyRequestCategoryPage

What changes do you think we should make in order

We will be deleting the component here:

App/src/pages/iou/MoneyRequestCategoryPage.js

Lines 45 to 49 in 93e68b5

    
           function MoneyRequestCategoryPage({route, report, iou}) { 
        
               const styles = useThemeStyles(); 
        
               const {translate} = useLocalize(); 
        
               const reportID = lodashGet(route, 'params.reportID', '');

This file will be removed. Checking history (link), it seems like useTheme import was updated, which seems correct in IOURequestStepCategory.js.

We will remove the screen from ModalStackNavigators.tsx

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 100 in 93e68b5

    
           [SCREENS.MONEY_REQUEST.CATEGORY]: () => require('../../../pages/iou/MoneyRequestCategoryPage').default as React.ComponentType,

  We will make sure the IOURequestStepCategory component works correctly.

Please re-state the problem that we are trying to solve in this issue.

We want to remove the MoneyRequestCategoryPage and make sure any changes after November 27 have been included into these new components.

What is the root cause of that problem?

This is a part of the Wave 5 cleanup effort, so the goal is to refactor the navigation among screens.

What changes do you think we should make in order to solve the problem?

A new component IOURequestStepCategory has been created and history has been checked against MoneyRequestCategoryPage.
There is only one change since November 27 which moved the location of the useThemeStyles import was changed to Line 10 instead of 13, so no changes need to be copied into the IOURequestStepCategory because it is already ikn there.

App/src/pages/iou/MoneyRequestCategoryPage.js

Line 10 in a7a3e7f

import useThemeStyles from '@hooks/useThemeStyles';

3 and 4. The only instance where this component is called and needs to be replaced with new component is

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 100 in a7a3e7f

[SCREENS.MONEY_REQUEST.CATEGORY]: () => require('../../../pages/iou/MoneyRequestCategoryPage').default as React.ComponentType,
The route will then need to be updated in (if applicable)

App/src/ROUTES.ts

Line 363 in d9ee78d

route: ':action/:iouType/scan/:transactionID/:reportID',
I didn't see any updating logic in this file, so we should be able to skip this step here

What alternative solutions did you explore? (Optional)

N/A

I would love to take this!

Job added to Upwork: https://www.upwork.com/jobs/~01aa1b22b861ac0e42

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Rotating for backup during my OOO till Feb 29th

PR is being actively reviewed

PR was deployed to staging a few hours ago!

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

This was deployed to prod on 2/28, seems the automation didn't work so am updating manually

@dukenv0307

Summarizing payment on this issue:

Contributor: @dukenv0307 $250 PAID via Upwork
Contributor+: @DylanDylann $250 PAID via Upwork

Upwork job is here: https://www.upwork.com/jobs/~01aa1b22b861ac0e42

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-04] [$250] Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js #34606

Problem

Solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

38 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function MoneyRequestCategoryPage({route, report, iou}) {
	const styles = useThemeStyles();
	const {translate} = useLocalize();

	const reportID = lodashGet(route, 'params.reportID', '');

[HOLD for payment 2024-03-04] [$250] Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js #34606

Description

Problem

Solution

Activity

melvin-bot commented on Jan 16, 2024

neonbhai commented on Jan 16, 2024

tgolen commented on Jan 16, 2024

neonbhai commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

lindseydortch commented on Jan 16, 2024

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

njmulsqb commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

38 remaining items

melvin-bot commented on Feb 16, 2024

anmurali commented on Feb 16, 2024

stephanieelliott commented on Feb 19, 2024

stephanieelliott commented on Feb 27, 2024

melvin-bot commented on Feb 28, 2024

stephanieelliott commented on Mar 5, 2024

stephanieelliott commented on Mar 6, 2024

melvin-bot commented on Mar 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions