[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Tag - Tag list shows old tag as selected when newer tag is selected in Split scan request

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.50-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

User is an employee of Collect workspace.
The Collect workspace has tags.

Go to staging.new.expensify.com
Go to workspace chat.
Go to + > Split bill > Scan.
Create a scan split with a tag.
Click on the split preview.
Click Tag.
Select a different tag.
Click Tag.

Expected Result:

The Tag list will show the newly-selected tag on the top

Actual Result:

The Tag list shows the original tag selected in Step 4 on the top.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6409569_1710160072688.tag.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017e2d605b4f1b0cbe
Upwork Job ID: 1767210397356195840
Last Price Increase: 2024-03-11
Automatic offers:

DylanDylann | Reviewer | 0

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@mountiny

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@greg-schroeder

We think that this bug might be related to #wave6-collect-submitters
cc @greg-schroeder

@FitseTLT

Seems like this might be related to @FitseTLT @puneetlath @neil-marcellini @ishpaul777 #37879

looking into it...

Proposal

Please re-state the problem that we are trying to solve in this issue.

The edited tag isn't applied in split bill request

What is the root cause of that problem?

In split bill requests, we save the draft data in splitDraftTransaction field instead of transaction field. But in here, we always get tag from transaction field

App/src/pages/iou/request/step/IOURequestStepTag.js

Line 90 in bf1ff4c

const tag = TransactionUtils.getTag(transaction, tagIndex);

What changes do you think we should make in order to solve the problem?

We should use information from the splitDraftTransaction field if isEditingSplitBill is true like we did in IOURequestStepCategory

App/src/pages/iou/request/step/IOURequestStepCategory.js

Line 76 in bf1ff4c

    
           const {category: transactionCategory} = ReportUtils.getTransactionDetails(isEditingSplitBill && !lodashIsEmpty(splitDraftTransaction) ? splitDraftTransaction : transaction);

   const isEditingSplitBill = isEditing && iouType === CONST.IOU.TYPE.SPLIT;
    // const tag = TransactionUtils.getTag(transaction, tagIndex);    // remove
    const tag = TransactionUtils.getTag(isEditingSplitBill && !lodashIsEmpty(splitDraftTransaction) ? splitDraftTransaction : transaction, tagIndex);

What alternative solutions did you explore? (Optional)

@ishpaul777

@ishpaul777 This issue isn't caused by #37879

While migrating the logic to IOURequestStepPage in here, they missed this case

@nkdengineer

@nkdengineer are you suggesting the issue is not a deploy blocker, means also repro on production ?

@nkdengineer

Agree with @nkdengineer. I noticed this bug and reported here. Could I take over this issue as a C+ role?

@mountiny

Actually i can handle this one if @mountiny agrees..

@DylanDylann

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix/38042: Tag list show old tag #38073

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

@DylanDylann requires payment automatic offer (Reviewer)
@nkdengineer requires payment (Needs manual offer from BZ)

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@nkdengineer

Hey @nkdengineer, could you please apply to the Upwork job (https://www.upwork.com/jobs/~017e2d605b4f1b0cbe), or alternatively, link to your Upwork profile here so that I can send you an offer?

@DylanDylann could you please complete the BZ checklist?

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition::

User is an employee of Collect workspace.
The Collect workspace has tags.

Go to staging.new.expensify.com
Go to workspace chat.
Go to + > Split bill > Scan.
Create a scan split with a tag.
Click on the split preview.
Click Tag.
Select a different tag.
Click Tag.
The Tag list will show the newly-selected tag on the top

Do we agree 👍 or 👎

We'll add test steps once the feature is fully implemented. No need to add them now.

@nkdengineer

Summarizing payment on this issue:

Contributor: @nkdengineer $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/101491657)
Contributor+: @DylanDylann $500, paid via Upwork

@nkdengineer please let me know once you've accepted the offer.

@sakluger

@sakluger I've accepted the offer, thanks.

Thank you! All contracts have been paid out.

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Tag - Tag list shows old tag as selected when newer tag is selected in Split scan request #38042

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

38 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Tag - Tag list shows old tag as selected when newer tag is selected in Split scan request #38042

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Mar 11, 2024

melvin-bot commented on Mar 11, 2024

kbecciv commented on Mar 11, 2024

mountiny commented on Mar 11, 2024

ishpaul777 commented on Mar 11, 2024

nkdengineer commented on Mar 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented on Mar 11, 2024

nkdengineer commented on Mar 11, 2024

ishpaul777 commented on Mar 11, 2024

DylanDylann commented on Mar 11, 2024

ishpaul777 commented on Mar 11, 2024

38 remaining items

melvin-bot commented on Mar 13, 2024

melvin-bot commented on Mar 13, 2024

sakluger commented on Mar 18, 2024

DylanDylann commented on Mar 19, 2024

luacmartins commented on Mar 19, 2024

sakluger commented on Mar 20, 2024

nkdengineer commented on Mar 22, 2024

sakluger commented on Mar 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions