remove MoneyRequestTagPage by dukenv0307 · Pull Request #35136 · Expensify/App

dukenv0307 · 2024-01-25T08:00:29Z

Details

Remove all use of MoneyRequestTagPage
Use IOURequestStepTag for both create and edit case
Add action param for the route of IOURequestStepTag
EditRequestTagPage will be removed after remove all use of EditRequestPage

Fixed Issues

$ #34612
PROPOSAL: #34612 (comment)

Tests

Verify that MoneyRequestTagPage is removed with the route, screen, and all use of this page in the app
Create a request money and select a tag
Go to transaction thread report
Verify that selected tag is displayed as well
Click on tag to edit
Verify that the route has this format :action/:iouType/tag/:transactionID/:reportID and action param in URL is edit
Select onther tag and verify that tag is editted successfully

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Verify that MoneyRequestTagPage is removed with the route, screen, and all use of this page in the app
Create a request money and select a tag
Go to transaction thread report
Verify that selected tag is displayed as well
Click on tag to edit
Verify that the route has this format :action/:iouType/tag/:transactionID/:reportID and action param in URL is edit
Select onther tag and verify that tag is editted successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-25.at.14.39.54.mov

Android: mWeb Chrome

Screen.Recording.2024-01-25.at.14.13.06.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-01-25.at.14.10.25.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-25.at.14.09.16.mov

MacOS: Desktop

Screen.Recording.2024-01-25.at.14.41.18.mov

melvin-bot · 2024-01-25T08:01:10Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2024-01-30T14:47:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-01-31.at.23.16.04.mp4

Android: mWeb Chrome

CleanShot.2024-01-31.at.23.22.52.mp4

iOS: Native

CleanShot.2024-02-02.at.18.53.29.mp4

CleanShot.2024-01-31.at.18.02.27.mp4

iOS: mWeb Safari

CleanShot.2024-01-31.at.18.06.06.mp4

CleanShot.2024-01-31.at.18.08.02.mp4

MacOS: Chrome / Safari

CleanShot.2024-02-02.at.19.29.13.mp4

CleanShot.2024-01-31.at.17.52.04.mp4

MacOS: Desktop

Screen.Recording.2024-01-31.at.11.28.31.PM.mov

fedirjh · 2024-01-30T16:47:31Z

@dukenv0307 I get this crash when I tried an IOU request:

dukenv0307 · 2024-01-31T04:16:53Z

@fedirjh Updated to use lodashGet to avoid crashing.

dukenv0307 · 2024-02-01T04:34:07Z

As another PR that I'm working, I also updated to implement edit split bill in IOURequestStepTag.

fedirjh

Looks good, left few comments about the code.

cc @tgolen Would like to tag you to get a quick review.

dukenv0307 · 2024-02-02T03:30:11Z

@fedirjh Updated your suggestion to fix minor issue.

fedirjh

Looks good and tests well.

MariaHCD

There's a merge conflict but otherwise looks good!

dukenv0307 · 2024-02-05T07:32:42Z

@MariaHCD I resolved conflict.

OSBotify · 2024-02-05T08:32:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T23:09:28Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-05T23:31:13Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

kavimuru · 2024-02-05T23:39:24Z

@dukenv0307 could you explain the step 1

Verify that MoneyRequestTagPage is removed with the route, screen, and all use of this page in the app

kavimuru · 2024-02-06T15:01:50Z

@dukenv0307 @tgolen should we ignore step 1?

Verify that MoneyRequestTagPage is removed with the route, screen, and all use of this page in the app

dukenv0307 · 2024-02-06T15:05:47Z

@kavimuru Yeah, I think we can ignore this and only test the flow. It's just a locally test to check the code.

OSBotify · 2024-02-07T09:51:37Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

hoangzinh · 2024-02-08T17:20:31Z

+                                    );
                                    return;
                                }
                                Navigation.navigate(ROUTES.MONEY_REQUEST_TAG.getRoute(props.iouType, props.reportID));


Hi @dukenv0307, I saw that we removed ROUTES.MONEY_REQUEST_TAG in this PR, but this line of code is still using it. Is it something we missed?

jjcoffee · 2024-02-16T15:45:08Z

-            IOU.setMoneyRequestTag_temporaryForRefactor(transactionID, selectedTag.searchText);
+        const isSelectedTag = selectedTag.searchText === tag;
+        const updatedTag = !isSelectedTag ? selectedTag.searchText : '';
+        if (isSplitBill) {


Coming from #35836. This uses the SPLIT_TRANSACTION_DRAFT Onyx key, whereas we use the TRANSACTION_DRAFT key when creating a request, so we end up updating the wrong key here.

DylanDylann · 2024-03-19T14:42:51Z

-        params: {transactionID, backTo},
+        params: {action, transactionID, backTo, iouType},
    },
    transaction: {tag},


In split bill requests, we save the draft data in splitDraftTransaction field instead of transaction field. But in here, we always get tag from transaction field. It causes this regression

remove MoneyRequestTagPae

41bc02b

dukenv0307 marked this pull request as ready for review January 25, 2024 08:01

dukenv0307 requested a review from a team as a code owner January 25, 2024 08:01

melvin-bot Bot requested review from fedirjh and removed request for a team January 25, 2024 08:01

Merge branch 'main' into fix/34612

c6320c2

fedirjh reviewed Jan 30, 2024

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepTag.js Resolved

Comment thread src/pages/iou/request/step/IOURequestStepTag.js Resolved

dukenv0307 added 2 commits January 31, 2024 11:06

Merge branch 'main' into fix/34612

b7e4728

34612

414136a

fix lint

17f3d48

fedirjh reviewed Jan 31, 2024

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepTag.js Resolved

dukenv0307 added 2 commits February 1, 2024 10:39

Merge branch 'main' into fix/34612

4fc9f76

refactor logic to update tag and implement for split flow

c78b434

fedirjh reviewed Feb 1, 2024

View reviewed changes

Comment thread src/components/MoneyTemporaryForRefactorRequestConfirmationList.js Resolved

Comment thread src/pages/iou/MoneyRequestTagPage.js Resolved

Comment thread src/pages/iou/request/step/IOURequestStepTag.js Resolved

Comment thread src/pages/iou/request/step/IOURequestStepTag.js Resolved

dukenv0307 added 2 commits February 2, 2024 10:13

resolve conflict

2d90382

revert hard code and rename variable

53e3ae8

tgolen previously approved these changes Feb 2, 2024

View reviewed changes

fedirjh approved these changes Feb 2, 2024

View reviewed changes

melvin-bot Bot requested a review from MariaHCD February 2, 2024 18:38

MariaHCD reviewed Feb 5, 2024

View reviewed changes

merge main

7fe79d8

dukenv0307 dismissed tgolen’s stale review via 7fe79d8 February 5, 2024 07:32

MariaHCD approved these changes Feb 5, 2024

View reviewed changes

MariaHCD merged commit 6c2882a into Expensify:main Feb 5, 2024

lindboe mentioned this pull request Feb 5, 2024

Client-side violations for money request updates #34402

Merged

50 tasks done

github-actions Bot mentioned this pull request Feb 5, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks done

jjcoffee mentioned this pull request Feb 6, 2024

[HOLD for payment 2024-02-19] [$500] [LOW] Selecting tag on Split bill does not work #35836

Closed

1 of 6 tasks

melvin-bot Bot mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js #34612

Closed

hoangzinh reviewed Feb 8, 2024

View reviewed changes

hoangzinh mentioned this pull request Feb 13, 2024

[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #34168

Merged

50 tasks done

jjcoffee reviewed Feb 16, 2024

View reviewed changes

nkdengineer mentioned this pull request Mar 11, 2024

[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Tag - Tag list shows old tag as selected when newer tag is selected in Split scan request #38042

Closed

6 tasks done

DylanDylann reviewed Mar 19, 2024

View reviewed changes

Conversation

dukenv0307 commented Jan 25, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 25, 2024

Uh oh!

fedirjh commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

fedirjh commented Jan 30, 2024

Uh oh!

dukenv0307 commented Jan 31, 2024

Uh oh!

Uh oh!

dukenv0307 commented Feb 1, 2024

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dukenv0307 commented Feb 2, 2024

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

MariaHCD left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

kavimuru commented Feb 5, 2024

Uh oh!

kavimuru commented Feb 6, 2024

Uh oh!

dukenv0307 commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

hoangzinh Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

jjcoffee Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

fedirjh commented Jan 30, 2024 •

edited

Loading

dukenv0307 commented Feb 6, 2024 •

edited

Loading

jjcoffee Feb 16, 2024 •

edited

Loading