Repository navigation
Deploy Checklist: New Expensify 2024-02-05 #35857
Description
Release Version: 1.4.37-7
Compare Changes: production...staging
This release contains changes from the following pull requests:
- fix: 22383 Whole thread disappears if the thread header is flagged as an Assault or Harassment #28002
- Fixed currency selection on confirm step #34075
- [TS migration] Migrate 'IOU.js' lib to TypeScript #34092
- Migrate welcome message to room description for report #34150
- [TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript #34564
- [TS migration] Migrate 'ReportShareCode' page to TypeScript #34580
- Implement get all ancestor of the thread #34640
- refactor: move methods to personalDetailsUtils, remove unused one #34657
- Allow users to permanently dismiss the referral banners #34842
- Fix error message display bug on google signin #34863
- FIX: Implement pattern C for money reports with various currencies #35062
- Money Request "no results found" header fix #35077
- remove MoneyRequestTagPage #35136
- Delete docs/articles/expensify-classic/getting-started/Individual-Use… #35186
- Fix/33420: Allow member to edit task #35219
- Android-Attachments-App crashes on uploading specific PDF #35222
- Pare back the parallax animation on empty chats #35232
- [TS migration] Migrate 'SettingsProfileReport' page to TypeScript #35321
- [HelpDot] Add platform tabs #35329
- Fix the second avatar border color doesn't match the background when hovered in search page #35354
- Fix red dot error doesn't show on LHN #35356
- Fix/34415: Hide error if request is paid #35360
- remove unused popover ref callbacks #35402
- Fix can't go back after opening a public room as anonymous user and reopen the app #35453
- fix: prevent crash on Backspace press when magic input is not focused #35454
- Fix: Web - Settings - The same text is also displayed as tooltips #35460
- [HelpDot] add selector #35510
- fix: Invalid file is downloaded when uploading invalid file and downloading from receipt view #35536
- Remove zero width space when copying email #35557
- feat: Remove the "Leave thread" option from the context menu #35573
- Revert "[CP Staging] Revert "[NO QA] Remove areChatRoomsEnabled checks"" #35576
- fixes crash on long press expensify classic option #35601
- Fix extra padding of back button and tooltip #35643
- Fix/35507: Missing tooltip close button #35646
- Fix type error in linkTo #35668
- [HelpDot] rm extra li tag #35762
- fix: IOU - Enter click does not deselect/select user in split bill. #35773
- fix: Focusing emoji search input on mWeb #35796
- fix clicking back button takes user to wrong page from avatar preview… #35807
- Update redirects.csv #35825
- [Fix]: Updated tooltip text #35828
- Fix vulnerability in "follow-redirects" package #35849
- Fix header for room description #35900
- [TS Migration] Follow-up PR to fix crash on MoneyRequestPreview #35916
- [CP Staging] Fix warning on the server #35918
- Share Code Page fix #35924
- [CP Staging] Fix broken navigation to transaction thread while offline #35937
- Hide Subscriptions menu item on iOS and Android native #35953
Deploy Blockers:
- [HOLD for payment 2024-02-14] [$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page. #35782
- [Ready for payment][$500] Chat - Skeleton in the header is not aligned with skeleton in the chat #35892
- [$500] IOU - Page shows spinner after returning from Amount editor in confirmation page #35893
- [$500] Expense - "Pay with Expensify" button is grayed out briefly after requesting money #35894
- [$500] Referral - Referral banner is not permanently dismissed in Search #35895
- Room - Adding markdown to room description appears and then disappears #35901
- [HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] IOU - 'Hmm.. it's not here' page is displayed when opening IOU report details page #35904
- [Pay 2024-03-06][$500] [CRITICAL] Backwards Compatibility: Disabled tag is not displayed in the list as selected #35909
- [$500] Thread - Some of the threads can't be opened from the LHN #35914
- [HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$500] 0 is showing up in black small font in split bill preview #35915
- IOS - Tapping Download on “Share code” doesn’t always work #35919
- Split scan - On creating Split scan in WS, shows 0 in preview in mweb , app crashes in android #35942
- Bank account - Form is filled with data entered on previous add BA flow #35944
- Split - Avatar is opened with delay when accessing from split bill confirmation page #35966
- [HOLD App#35519] Android - Bank account - App crashes after filling out personal info offline killing app&go online #35974
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
marcaaron commentedon Feb 6, 2024
Quick heads up that the latest app versions are not yet available, but we are working on it.
kavimuru commentedon Feb 6, 2024
@marcaaron please let us know when we can start the regression once the latest version available. I can see 1.4.37-0 in web, mweb and android
marcaaron commentedon Feb 6, 2024
All versions should be successfully updated now!
kavimuru commentedon Feb 6, 2024
@marcaaron are we okay to test in 1.4.37-0. I don't see 1.4.37-1 version though.
OSBotify commentedon Feb 6, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.37-0 🚀
marcaaron commentedon Feb 6, 2024
Hmm I believe so. I don't think there is a real
1.4.37-1and that was just a quirk of the failed initial deploy - but double checking...marcaaron commentedon Feb 6, 2024
I am 99% certain that the 1.4.37-0 has everything 👍
rlinoz commentedon Feb 6, 2024
Demoting #35892
luacmartins commentedon Feb 6, 2024
Checking off #35893. expected behavior
kavimuru commentedon Feb 6, 2024
Regression is 34% progress
#28002 to be validated in all the platforms
#34092 to be validated in all the platforms
#34150 to be validated in all the platforms
#34564 to be validated in all the platforms
#34657 to be validated in all the platforms
#34842 to be validated in all the platforms
#35062 to be validated in all the platforms
#35232 to be validated in all the platforms
#35454 to be validated in all the platforms
#34580 failing with #35919
#35460 failing with same KI #34961 (web, desktop) OK to check it off?
#35557 failing with KI #34437 (web, desktop) OK to check it off?
#34640 failing with #35914
kavimuru commentedon Feb 6, 2024
Regression is at 60%
#34580 failing with #35919
#35460 failing with same KI #34961 (#35460 (comment)) - Repro in PROD check it off.
#35557 failing with KI #34437 (#35557 (comment)) - Repro in PROD check it off.
#34640 failing with #35914
#28002 failing with KI #34151 in all the environments (#28002 (comment)) - Repro in PROD check it off.
#34092 failing with #35942
#34150 failing with #35901
#34842 failing with #35895
amyevans commentedon Feb 6, 2024
Demoted #35914
5 remaining items
marcaaron commentedon Feb 7, 2024
Checking off #35904 as per this comment
marcaaron commentedon Feb 7, 2024
Checking off #35919 as I confirmed it is fixed in the TestFlight build.
mvtglobally commentedon Feb 7, 2024
Regression i at 5% left
@marcaaron Can you check if these are ok to check off?
#34092 failing with #35942
#34150 failing with #35901
#34580 failing with #35919
#34640 failing with #35914
#34842 failing with #35895
marcaaron commentedon Feb 7, 2024
Yep those are all done. Thanks!
Julesssss commentedon Feb 7, 2024
I can verify that all but one of these issues have been CP'd and fixed, so I checked them off. I just need to look into #35914, as a new bug has been raised against it 👁️
Julesssss commentedon Feb 7, 2024
I'm checking off the final PR. The issue raised against it was deemed not to be a blocker.
Julesssss commentedon Feb 7, 2024
Julesssss commentedon Feb 7, 2024
os-botify commentedon Feb 7, 2024
This issue either has unchecked items or has not yet been marked with the
:shipit:emoji of approval.Reopening!
Julesssss commentedon Feb 7, 2024
Checked off the Firebase box...
Julesssss commentedon Feb 7, 2024