[TS migration] Migrate 'SettingsProfileReport' page to TypeScript by shahinyan11 · Pull Request #35321 · Expensify/App

shahinyan11 · 2024-01-29T16:25:57Z

Details

Fixed Issues

$ #25215
PROPOSAL: N/A

Tests

Open room chat
Go to room settings page
Navigate /notification-preferences, /room-name and /who-can-post screens
Verify that all screens works without errors

Verify that no errors appear in the JS console

Offline tests

Same as in the Tests section.

QA Steps

Same as in the Tests section.

[x ] Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Untitled.mov

Android: mWeb Chrome

Screenrecorder-2024-01-29-20-23-15-386.0.mp4

iOS: Native

Untitled.mov

iOS: mWeb Safari

Screen.Recording.2024-01-29.at.19.48.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-29.at.18.31.57.mov

MacOS: Desktop

Screen.Recording.2024-01-29.at.18.35.40.mov

melvin-bot · 2024-01-29T16:26:02Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010

Waiting for the commits with fixes

fabioh8010

minor comment, LGTM

fabioh8010

@s77rt is right @shahinyan11 , we can get rid of these changes in the Utils files if we just default linkedWorkspace to null, please check my suggestions

shahinyan11 · 2024-02-01T17:21:13Z

@s77rt What about this ?

s77rt · 2024-02-05T00:42:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-02-05T00:45:03Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25215 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

s77rt · 2024-02-05T00:45:32Z

cc @nkuoch

OSBotify · 2024-02-05T13:44:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T23:09:43Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-05T23:31:28Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-07T09:51:52Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

eh2077 · 2024-03-11T10:19:26Z

                            </View>
                        )}
-                        {Boolean(report.visibility) && (
+                        {report?.visibility !== undefined && (


This change introduced a bug #37445

Shahe Shahinyan added 2 commits January 26, 2024 21:07

Init changes to migrate

4459b37

Pull last main

031ce35

melvin-bot Bot requested review from s77rt and removed request for a team January 29, 2024 16:26

Shahe Shahinyan added 6 commits January 29, 2024 20:51

Fix screens crash

853932d

add translation key for es

b544a69

Fix TS and lint errors

ff010eb

Fix Ts error

52670ab

Fix lint errors

0ccafa8

Run prettier

fe014b7

s77rt suggested changes Jan 30, 2024

View reviewed changes

fabioh8010 reviewed Jan 30, 2024

View reviewed changes

s77rt suggested changes Jan 31, 2024

View reviewed changes

Comment thread src/libs/PolicyUtils.ts Resolved

fabioh8010 reviewed Feb 1, 2024

View reviewed changes

Comment thread src/libs/ErrorUtils.ts Resolved

Comment thread src/libs/PolicyUtils.ts Resolved

Comment thread src/libs/PolicyUtils.ts Resolved

Shahe Shahinyan added 4 commits February 1, 2024 17:47

Addressed to reviewer comments

17f25fc

Addressed to reviewer comments

7495142

Pull last main and resolve conflicts

ae000da

run prettier

e2c935c

fabioh8010 approved these changes Feb 1, 2024

View reviewed changes

Comment thread src/pages/settings/Report/ReportSettingsPage.tsx Resolved

s77rt suggested changes Feb 1, 2024

View reviewed changes

Comment thread src/libs/ReportUtils.ts Resolved

Addressed to reviewer comments

ba70fc9

fabioh8010 reviewed Feb 1, 2024

View reviewed changes

Addressed to reviewer comments

d07a1d5

Shahe Shahinyan added 2 commits February 2, 2024 14:17

Addressed to reviewer comments

0b2f0e6

Pull last main

d9892b8

s77rt suggested changes Feb 4, 2024

View reviewed changes

Shahe Shahinyan added 2 commits February 4, 2024 14:23

Addressed to reviewer comments

b742d66

Pull last main and resolve conflicts

70d6848

s77rt suggested changes Feb 4, 2024

View reviewed changes

Comment thread src/pages/settings/Report/ReportSettingsPage.tsx Resolved

Comment thread src/pages/settings/Report/ReportSettingsPage.tsx Resolved

Addressed to reviewer comments

84317af

s77rt approved these changes Feb 5, 2024

View reviewed changes

nkuoch approved these changes Feb 5, 2024

View reviewed changes

nkuoch merged commit 4722815 into Expensify:main Feb 5, 2024

github-actions Bot mentioned this pull request Feb 5, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks done

lanitochka17 mentioned this pull request Feb 6, 2024

[$500] Room - Header does not show #room in <workspace> for room with description on web app #35911

Closed

1 of 6 tasks

melvin-bot Bot mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-14] [$250] [TS migration] Migrate 'SettingsProfileReport' page to TypeScript #25215

Closed

eh2077 reviewed Mar 11, 2024

View reviewed changes

Conversation

shahinyan11 commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahinyan11 commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 5, 2024

Uh oh!

s77rt commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

shahinyan11 commented Jan 29, 2024 •

edited

Loading

shahinyan11 commented Feb 1, 2024 •

edited

Loading

s77rt commented Feb 5, 2024 •

edited

Loading