fix: Invalid file is downloaded when uploading invalid file and downloading from receipt view by tienifr · Pull Request #35536 · Expensify/App

tienifr · 2024-02-01T04:13:53Z

Details

Fixed Issues

$ #35482
PROPOSAL:

Tests

Create a money request with receipt
Navigate to request details page
Click on the receipt > 3-dot menu > Replace
Upload a corrupted file
Click on the receipt preview > 3-dot menu > Download
Open the downloaded file
Verify that the downloaded file is the corrupted file

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Create a money request with receipt
Navigate to request details page
Click on the receipt > 3-dot menu > Replace
Upload a corrupted file
Click on the receipt preview > 3-dot menu > Download
Open the downloaded file
Verify that the downloaded file is the corrupted file

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-02.at.16.05.12.mov

Android: mWeb Chrome

Screen.Recording.2024-02-02.at.16.04.36.mov

iOS: Native

Screen.Recording.2024-02-02.at.16.05.56.mp4

iOS: mWeb Safari

Screen.Recording.2024-02-02.at.16.01.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-01.at.11.14.50.mov

MacOS: Desktop

Screen.Recording.2024-02-02.at.16.08.21.mov

…oading from receipt view

melvin-bot · 2024-02-01T04:15:59Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-02-01T04:16:10Z

@hoangzinh Can you help review it? Thanks

allroundexperts · 2024-02-01T07:57:52Z

Hi @tienifr!
Is this a regression? I am not sure why you mentioned @hoangzinh?

allroundexperts · 2024-02-01T07:59:09Z

Ah, I see it now. Un-assigning myself!

hoangzinh · 2024-02-01T13:56:24Z

                                thumbnail={receiptURIs.thumbnail}
                                image={receiptURIs.image}
                                isLocalFile={receiptURIs.isLocalFile}
+                                filename={receiptURIs.filename || transaction.filename}


Do we need a fallback value here?

I just want to use transaction.filename in case it's pending waypoint. But after checking, we don't need it anymore

hoangzinh · 2024-02-01T13:56:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-01.at.21.25.17.android.mov

Android: mWeb Chrome

Screen.Recording.2024-02-01.at.21.26.45.android.chrome.mov

iOS: Native

Screen.Recording.2024-02-01.at.21.17.59.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-02-01.at.21.16.33.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-01.at.21.07.12.web.mov

MacOS: Desktop

Screen.Recording.2024-02-01.at.21.13.05.desktop.mov

hoangzinh · 2024-02-01T14:06:18Z

@tienifr please upload recording for other platforms as well.

tienifr · 2024-02-02T09:09:52Z

@hoangzinh updated

hoangzinh

LGTM

OSBotify · 2024-02-02T17:15:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T23:10:10Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-05T23:31:59Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-07T09:52:22Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: Invalid file is downloaded when uploading invalid file and downl…

49895f6

…oading from receipt view

tienifr marked this pull request as ready for review February 1, 2024 04:15

tienifr requested a review from a team as a code owner February 1, 2024 04:15

melvin-bot Bot removed the request for review from a team February 1, 2024 04:15

melvin-bot Bot requested a review from allroundexperts February 1, 2024 04:15

hoangzinh reviewed Feb 1, 2024

View reviewed changes

tienifr added 2 commits February 2, 2024 15:24

Merge branch 'main' into fix/35482

a219455

remove fallback value

eca84a4

hoangzinh approved these changes Feb 2, 2024

View reviewed changes

melvin-bot Bot requested a review from luacmartins February 2, 2024 10:43

luacmartins approved these changes Feb 2, 2024

View reviewed changes

luacmartins merged commit e6ea03b into Expensify:main Feb 2, 2024

github-actions Bot mentioned this pull request Feb 5, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks done

melvin-bot Bot mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-14] Scan- Invalid file is downloaded when uploading invalid file and downloading from receipt view #35482

Closed

3 of 6 tasks

Conversation

tienifr commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 1, 2024

Uh oh!

tienifr commented Feb 1, 2024

Uh oh!

allroundexperts commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Feb 1, 2024

Uh oh!

hoangzinh Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Feb 2, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Feb 1, 2024

Uh oh!

tienifr commented Feb 2, 2024

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 2, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tienifr commented Feb 1, 2024 •

edited

Loading

allroundexperts commented Feb 1, 2024 •

edited

Loading

hoangzinh commented Feb 1, 2024 •

edited

Loading