Repository navigation
[Ready for payment][$500] Chat - Skeleton in the header is not aligned with skeleton in the chat #35892
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v.1.4-37.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
- Log out if logged in.
- Log in to staging.new.expensify.com
- Note that skeleton in the header.
Expected Result:
The skeleton in the header has the same alignment to the left as the skeleton in the chat.
Actual Result:
The skeleton in the header has extra margin on the left compared to the skeleton in the header.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01455b0defb7af246c
- Upwork Job ID: 1754825370662596608
- Last Price Increase: 2024-02-06
- Automatic offers:
- bernhardoj | Contributor | 0
Activity
[-]Chat - Skeleton in the header is not aligned with skeleton in the chat[/-][+][$500] Chat - Skeleton in the header is not aligned with skeleton in the chat[/+]melvin-bot commentedon Feb 6, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01455b0defb7af246c
melvin-bot commentedon Feb 6, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)melvin-bot commentedon Feb 6, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 6, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
50 remaining items
kadiealexander commentedon Apr 10, 2024
Sorry guys, this one slipped through the cracks!
kadiealexander commentedon Apr 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
kadiealexander commentedon Apr 10, 2024
Payment Summary
Upwork Job
BugZero Checklist (@kadiealexander)
[-][$500] Chat - Skeleton in the header is not aligned with skeleton in the chat[/-][+][Ready for payment][$500] Chat - Skeleton in the header is not aligned with skeleton in the chat[/+]thesahindia commentedon Apr 12, 2024
It was caused by #33280. It was a big PR so not sure if we could have prevented this.
I don't think we need a specific test case for this.
kadiealexander commentedon Apr 16, 2024
Payment summary for Newdot payer here.
JmillsExpensify commentedon Apr 30, 2024
$500 approved for @thesahindia
bernhardoj commentedon Jun 25, 2024
@kadiealexander hey, sorry, but I was checking my upwork and saw I haven't gotten paid for this one yet. The upwork offer link from this comment leads to this offer which I ended the contract just now because I don't work on #38935, so I thought it's an offer error.
I also see there is this old offer which is the correct one. Can you please recheck?
kadiealexander commentedon Jun 26, 2024
Sorry about that @bernhardoj! I've paid this for you.
bernhardoj commentedon Jun 26, 2024
Thanks!