[HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestTagPage
New Component IOURequestStepTags

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f0c8228cceba8683
Upwork Job ID: 1747632892276064256
Last Price Increase: 2024-01-17
Automatic offers:

fedirjh | Reviewer | 28119689
dukenv0307 | Contributor | 28119690

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js

What is the root cause of that problem?

Component update

What changes do you think we should make in order to solve the problem?

I checked all the commits after 27th Nov and the new component is updated according to the old component, we just need to remove the file and route created for it. I checked the commits thoroughly but will check again in the PR. There is only 1 commit after 27th Nov and it is about moving import of useThemeStyles.

Component to remove:
https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestTagPage.js

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 101 in a7a3e7f

    
           [SCREENS.MONEY_REQUEST.TAG]: () => require('../../../pages/iou/MoneyRequestTagPage').default as React.ComponentType,

We also need to remove all traces from src/libs/Navigation/types.ts & src/libs/Navigation/linkingConfig.ts

App/src/libs/Navigation/linkingConfig.ts

Line 434 in a2f5bd5

[SCREENS.MONEY_REQUEST.TAG]: ROUTES.MONEY_REQUEST_TAG.route,

App/src/libs/Navigation/types.ts

Line 214 in a2f5bd5

[SCREENS.MONEY_REQUEST.TAG]: {

Note: The below 2 steps can be omitted because we only use IOURequestStepTags for IOU creation flow.

Need to update to :action here:

App/src/ROUTES.ts

Line 367 in a2f5bd5

MONEY_REQUEST_STEP_TAG: {

We only need to pass the action from one component here:

App/src/components/MoneyRequestConfirmationList.js

Line 749 in a2f5bd5

Navigation.navigate(ROUTES.MONEY_REQUEST_TAG.getRoute(props.iouType, props.reportID));

Result

I would love to take this!

Job added to Upwork: https://www.upwork.com/jobs/~01f0c8228cceba8683

@fedirjh

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js

What is the root cause of that problem?

This is a refactor

What changes do you think we should make in order to solve the problem?

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes

The history change here: https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestTagPage.js

We have had one change since Nov 27, 2023 but it's the refactoring change and has already been applied in IOURequestStepTags. So no need to change here.

Replace all uses of the Old Component with the New Component
Remove all traces of Old Component

MoneyRequestTagPage isn't used in any component so we don't need to have any updates here.

We only need to remove MoneyRequestTagPage in ModalStackNavigators, remove .MONEY_REQUEST.TAG from SCREENS, and remove MONEY_REQUEST_TAG route

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 98 in a8acf44

    
           [SCREENS.MONEY_REQUEST.DATE]: () => require('../../../pages/iou/MoneyRequestDatePage').default as React.ComponentType,

Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")

Update the getRoute function with an extra param action and return it instead of always returning create

getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo: string) =>
            getUrlWithBackToParam(`${action}/${iouType}/tag/${transactionID}/${reportID}`, backTo),

App/src/ROUTES.ts

Lines 339 to 340 in a8acf44

    
           getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') => 
        
               getUrlWithBackToParam(`create/${iouType}/date/${transactionID}/${reportID}`, backTo),

Update any logic like isEditing to use the new action param from the route

We need to update updateTag function in IOURequestStepTags for the edit case by checking action params. For edit case, we can re-use the logic of saveTag function in EditRequestPage.

And when we click on tag on MoneyRequestView we will navigate to IOURequestStepTags with action param is edit.

After this refactor we can remove EditRequestTagPage.

What alternative solutions did you explore? (Optional)

NA

Reviewing label has been removed, please complete the "BugZero Checklist".

@fedirjh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

remove MoneyRequestTagPage #35136

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment automatic offer (Reviewer)
@dukenv0307 requires payment automatic offer (Contributor)

@fedirjh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@fedirjh

I don't think the BZ checklist applies here since this was more a feature update and not really a bug (please check me on that @fedirjh!)

@dukenv0307

Summarizing payment on this issue:

Contributor: @dukenv0307 $250, paid via Upwokr
Contributor+: @fedirjh $250, paid via Upwokr

Upwork job is here: https://www.upwork.com/jobs/~01f0c8228cceba8683

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js #34612

Problem

Solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

25 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`create/${iouType}/date/${transactionID}/${reportID}`, backTo),

[HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js #34612

Description

Problem

Solution

Activity

melvin-bot commented on Jan 16, 2024

Krishna2323 commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

njmulsqb commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

dukenv0307 commented on Jan 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

25 remaining items

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

stephanieelliott commented on Feb 16, 2024

stephanieelliott commented on Feb 16, 2024

melvin-bot commented on Mar 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions