[HOLD for payment 2024-02-26] [$250] Remove MoneyRequestMerchantPage.js and copy any changes since Nov 27 into IOURequestStepMerchant.js

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestMerchantPage
New Component IOURequestStepMerchant

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013e56ba72ea82ea62
Upwork Job ID: 1747386410233479168
Last Price Increase: 2024-01-24
Automatic offers:

hoangzinh | Reviewer | 28132635
DylanDylann | Contributor | 28132636

@joekaufmanexpensify

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

I can help work on this!

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestMerchantPage.js and copy any changes since Nov 27 into IOURequestStepMerchant.js

What is the root cause of that problem?

Clean Up  of MoneyRequestMerchantPage

What changes do you think we should make in order to solve this problem?

We will be deleting the component here:

App/src/pages/iou/MoneyRequestMerchantPage.js

Lines 50 to 52 in a7a3e7f

    
           function MoneyRequestMerchantPage({iou, route}) { 
        
               const styles = useThemeStyles(); 
        
               const {translate} = useLocalize();

This file will be removed. Checking history (link), we have had a few updates. We will be going through each and applying these to the new component.

We will remove the screen from ModalStackNavigators.tsx

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 102 in a7a3e7f

    
           [SCREENS.MONEY_REQUEST.MERCHANT]: () => require('../../../pages/iou/MoneyRequestMerchantPage').default as React.ComponentType,

Job added to Upwork: https://www.upwork.com/jobs/~013e56ba72ea82ea62

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

I can help working on this!

I would love to take this!

Reviewing label has been removed, please complete the "BugZero Checklist".

@hoangzinh

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix/34611: Remove old merchant page #35641

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment automatic offer (Reviewer)
@DylanDylann requires payment automatic offer (Contributor)

@hoangzinh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR: N/A
[@hoangzinh / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@hoangzinh / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@hoangzinh / @DylanDylann] Determine if we should create a regression test for this bug.
[@hoangzinh / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

@hoangzinh

@hoangzinh is any BZ checklist needed here?

@joekaufmanexpensify

@joekaufmanexpensify nope, I think. This issue is not a bug fix.

Sounds good! All set to issue payment on the 26th then.

@hoangzinh

All set to issue payment. We need to pay:

@hoangzinh $250 for C+. Paid via upwork.
@DylanDylann $250 for PR. Paid via upwork.

@hoangzinh

@hoangzinh $250 sent and contract ended!

@DylanDylann

@DylanDylann $250 sent and contract ended!

@maddylewis

I also noticed @maddylewis issued a third offer for this job to a different contributor. I don't see this contributor worked on this job, so thinking this was by mistake. Checking with Maddy, but not blocking on this, since all of the actual payments have been issued.

All set. Thanks everyone!

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-26] [$250] Remove MoneyRequestMerchantPage.js and copy any changes since Nov 27 into IOURequestStepMerchant.js #34611

Problem

Solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve this problem?

58 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function MoneyRequestMerchantPage({iou, route}) {
	const styles = useThemeStyles();
	const {translate} = useLocalize();

[HOLD for payment 2024-02-26] [$250] Remove MoneyRequestMerchantPage.js and copy any changes since Nov 27 into IOURequestStepMerchant.js #34611

Description

Problem

Solution

Activity

melvin-bot commented on Jan 16, 2024

neonbhai commented on Jan 16, 2024

neonbhai commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve this problem?

melvin-bot commented on Jan 16, 2024

melvin-bot commented on Jan 16, 2024

abzokhattab commented on Jan 16, 2024

njmulsqb commented on Jan 17, 2024

58 remaining items

melvin-bot commented on Feb 19, 2024

melvin-bot commented on Feb 19, 2024

melvin-bot commented on Feb 19, 2024

joekaufmanexpensify commented on Feb 23, 2024

hoangzinh commented on Feb 23, 2024

joekaufmanexpensify commented on Feb 23, 2024

joekaufmanexpensify commented on Feb 26, 2024

joekaufmanexpensify commented on Feb 26, 2024

joekaufmanexpensify commented on Feb 26, 2024

joekaufmanexpensify commented on Feb 26, 2024

joekaufmanexpensify commented on Feb 26, 2024

melvin-bot commented on Mar 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions