Repository navigation
[$500] Expense - Old amount is copied to clipboard when the request amount is changed #36911
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.43-3
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
- Navigate to staging.new.expensify.com
- Go to workspace chat.
- Create a manual request.
- Go to the request details page.
- Change the amount and save it.
- Return to expense report.
- Right click on the preview > Copy to clipboard.
- Paste the content.
Expected Result:
The new amount is copied.
Actual Result:
The old amount is copied.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6385702_1708434078212.bandicam_2024-02-20_16-17-50-524.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~015fa30e8940937ece
- Upwork Job ID: 1759966128870391808
- Last Price Increase: 2024-02-20
Activity
[-]Expense - Old amount is copied to clipboard when the request amount is changed[/-][+][$500] Expense - Old amount is copied to clipboard when the request amount is changed[/+]melvin-bot commentedon Feb 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~015fa30e8940937ece
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)github-actions commentedon Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @puneetlath (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Feb 20, 2024
We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify
hoangzinh commentedon Feb 20, 2024
Looks like a regression from #36298
shahinyan11 commentedon Feb 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - Old amount is copied to clipboard when the request amount is changed
What is the root cause of that problem?
Regression as stated above
What changes do you think we should make in order to solve the problem?
const isIOUTransactionAction = originalMessage?.IOUTransactionIDand replace the check of
shouldConsiderScanningReceiptOrPendingRoutewith(isIOUTransactionAction || shouldConsiderScanningReceiptOrPendingRoute)in this conditionisIOUTransactionActionWhat alternative solutions did you explore? (Optional)
flodnv commentedon Feb 20, 2024
Working on it in #36917 (comment)
shahinyan11 commentedon Feb 20, 2024
@flodnv this issue was opened before the one you mentioned
melvin-bot commentedon Feb 20, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Feb 20, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
puneetlath commentedon Feb 21, 2024
Closing since the offending PR was reverted.