[$500] IOU - Description is not copied when copying IOU preview to clipboard

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.43-3
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Navigate to staging.new.expensify.com
Go to 1:1 DM.
Create an IOU with a description.
Go to IOU report.
Right click on the preview > Copy to clipboard.
Paste the content.
Note that the description is not copied anymore

Expected Result:

The copied content will include the description, and it will be "requested $ for y".

Actual Result:

The copied content does not include the description, and it is just "requested $".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6385812_1708441940728.20240220_211542.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fae159a80486a6f8
Upwork Job ID: 1759970659438272512
Last Price Increase: 2024-02-20

Job added to Upwork: https://www.upwork.com/jobs/~01fae159a80486a6f8

@alitoshmatov

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@flodnv

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@davidcardoza

We think that this bug might be related to #vip-bills
CC @davidcardoza

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Old amount is copied to clipboard when the request amount is changed

What is the root cause of that problem?

Regression as stated above

What changes do you think we should make in order to solve the problem?

Define new variable const isIOUTransactionAction = originalMessage?.IOUTransactionID
and replace the check of shouldConsiderScanningReceiptOrPendingRoute with (isIOUTransactionAction || shouldConsiderScanningReceiptOrPendingRoute) in this condition

const isIOUTransactionAction = originalMessage?.IOUTransactionID

if (!isEmptyObject(reportAction) && (isIOUTransactionAction || shouldConsiderScanningReceiptOrPendingRoute ) && reportAction && ReportActionsUtils.isMoneyRequestAction(reportAction)) {

Move definition of originalMessage above definition of isIOUTransactionAction
Add below code here

const transactionDetails = getTransactionDetails(!isEmptyObject(linkedTransaction) ? linkedTransaction : null);

Change [this](Localize.translateLocal('iou.requestedAmount', {formattedAmount: amountToDisplay})) code with below

Localize.translateLocal('iou.requestedAmount', {formattedAmount: amountToDisplay, comment: transactionDetails?.comment ?? ''})

What alternative solutions did you explore? (Optional)

The offending PR is being reverted now

@paultsimura

@paultsimura Why revert if there is working solution

@flodnv

@flodnv My proposal will fix this issue and below issues
#36924
#36911

@srikarparsi

Leaving this to @srikarparsi - https://expensify.slack.com/archives/C01GTK53T8Q/p1708522618781829?thread_ts=1708444691.794139&cid=C01GTK53T8Q

Closing this out since the revert PR takes care of it and has been CPed

Navigation Menu

Repository navigation

[$500] IOU - Description is not copied when copying IOU preview to clipboard #36917

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

9 remaining items

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] IOU - Description is not copied when copying IOU preview to clipboard #36917

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 20, 2024

melvin-bot commented on Feb 20, 2024

github-actions commented on Feb 20, 2024

melvin-bot commented on Feb 20, 2024

kbecciv commented on Feb 20, 2024

9 remaining items

shahinyan11 commented on Feb 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

paultsimura commented on Feb 20, 2024

shahinyan11 commented on Feb 20, 2024

shahinyan11 commented on Feb 20, 2024

flodnv commented on Feb 21, 2024

srikarparsi commented on Feb 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions