Repository navigation
[$500] iOS - Settings - The keyboard appears with a black background that changes to grey #37301
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.44.0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Issue found when executing PR: #35326
Action Performed:
- Go to personal details
- Tap on address
- Tap on country
- Navigate back
- Tap on country again
Expected Result:
It should only show a grey background.
Actual Result:
The keyboard appears with a black background that changes to grey.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6393976_1709037272812.VYHS1315.1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0196694799b239c5ad
- Upwork Job ID: 1762484844314882048
- Last Price Increase: 2024-02-27
Activity
melvin-bot commentedon Feb 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0196694799b239c5ad
[-]iOS - Settings - The keyboard appears with a black background that changes to grey[/-][+][$500] iOS - Settings - The keyboard appears with a black background that changes to grey[/+]melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (
External)github-actions commentedon Feb 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to @rlinoz (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.ikevin127 commentedon Feb 27, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue
I was not able to find any offending PR within the deploy checklist, so I'm assuming this was not caused by the latest deploy.
What is the root cause of that problem?
We're not leveraging the iOS specific
keyboardAppearanceTextInput prop and because of this, the 'default' applies which will default to the appearance that the user has set globally on their device, which typically is a light keyboard but will be dark if the user has chosen to use the system-wide dark mode in their iOS settings.This can cause the unwanted transition from dark to light if not specifically set.
What changes do you think we should make in order to solve the problem?
Since the Expected result states:
this means we always want to show the light keyboard background.
For this we should explicitly set
keyboardAppearancetolighthere.Videos
iOS: Native
before.mov
after.mov
mkhutornyi commentedon Feb 27, 2024
I think #29991 is the offending PR.
So retest after #37305 is deployed to staging
puneetlath commentedon Feb 27, 2024
Can confirm it's working fine now after the revert. Closing this issue, but feel free to reopen if there's still something that needs to be done.