Repository navigation
Deploy Checklist: New Expensify 2024-02-26 #37224
Description
Release Version: 1.4.44-13
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Perf/native stack navigation #29991
- Fix/16184 base options selector refactoring #31606
- fix: check if the parent report is the archived room #31674
- [TS migration] Migrate 'IOUWaypoint' page to TypeScript #33244
- Update MentionUserRenderer.js Issue 26016 #33539
- Load map when image is not loaded in Money Request view for distance request #34133
- [TS migration] Migrate 'SettingsWalletDetails' page to TypeScript #34257
- Add offline feedback for deleted task action #34407
- Fix/status bar color on mweb #34409
- fix/33797: Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen #34464
- [TS migration] Migrate 'ReportReactionList' component to TypeScript #34549
- [TS migration] Migrate
SettingsWalletpage to TypeScript #34716 - [TS migration] Migrate 'WorkspaceNewRoom' page to TypeScript #34742
- [No QA] [TS Migration] Standardize approach to Onyx pendingFields #34799
- [TS Migration] Migrate WorkspaceProfilePage and WorkspaceProfileCurrencyPage #34897
- Mandatory exit survey for users going back to OldDot #34925
- [TS migration] Migrate 'WorkspaceMembers' page to TypeScript #35065
- fix logic get document from native #35164
- [TS migration] Migrate
SettingsProfileContactspage to TypeScript #35305 - [TS migration] Migrate 'SettingsProfileDetails' page to TypeScript #35307
- Fix always scrollable suggestion list #35319
- Fix/27263: Inconsistent validation error for required field in home address #35326
- [TS migration] Migrate 'ValidateCodeForm' component to TypeScript #35404
- Adds optimistic data for transaction threads with violations #35449
- Fix: show loading indicator for uncached attachments #35451
- Fix: menu popup can not be closed again #35452
- remove MoneyRequestCategoryPage and refactor route #35458
- 20354 category picker list refactor #35567
- Close the new chat page when pressing the back button #35568
- [TS migration] Migrate react-native-onyx mock #35674
- [TS migration] Migrate 'IOUMoneyRequest' page to TypeScript #35774
- Fix: Room visibility can’t be changed after a room is created #35830
- [TS migration] Migrate 'AvatarWithImagePicker.js' component to TypeSc… #35847
- Fix/35368: Composer is not shrinked #35865
- fix: Duplicate waypoint error message is not dimissed after closing distance editor #35910
- fix: [35383] zoomed large image disappears from preview if triple tap on the bottom of the screen #35931
- fix: Copy to clipboard on the system message for paid expense copies negative amount #35935
- Fix can't open the workspace after closing the workspace not found (unaccessible) page #35980
- [No QA] [TS migration] Migrate 'sanitizeStringForJSONParseTest.js' test to TypeScript #36026
- [ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number #36056
- [No QA] [TS migration] Migrate 'getStyledArratTest.js' test to TypeScript #36113
- [No QA] [TS migration] Migrate 'NumberUtilsTest.js' test to TypeScript #36116
- [TS migration] Migrate 'GooglePlacesUtilsTest.js' test to TypeScript #36146
- [No QA] [TS migration] Migrate 'TrieTest.js' test to TypeScript #36152
- Fix workspace switcher creating new workspace #36162
- truncate expense description on expense preview #36210
- Fix other chat is shown briefly when navigating to concierge page #36216
- Fix(35835) #36300
- 36218 cached viewport height conflict event #36302
- fix/35578 | Action menu for MP4 files has "Copy to clipboard" and "Edit comment" functions #36312
- [TS Migration] Migrate Math.js from e2e to Typescript #36321
- [TS migration] Migrate PaymentUtilsTest to Typescript #36323
- Feat/categories main page #36324
- [No QA] [TS migration] Migrate 'console.js' test to TypeScript #36326
- [Simplified Collect][Workflows] Create main workflow page (App) #36345
- Update Troubleshooting.md #36383
- Update Billing-Overview.md #36384
- Add helper functions in getMatchingCentralPaneRouteForState #36397
- [TS migration] Migrate 'SettingsInitial' page to TypeScript #36415
- [TS Migration] Migrate 'migrateOnyx.js' #36416
- Display correct name and avatar for notifications@expensify.com #36422
- [TS migration] Migrate GithubUtilsTest to typescript #36427
- fix/35934 | Workspaces - Сustom avatar is applied to all workspace rooms #36464
- [TS migration] Migrate killApp from E2E to typescript #36466
- [No QA][TS migration] Migrate 'ReportActionsUtilsTest.js' test to TypeScript #36482
- Setting the amount of Emojis to draw in FlashList #36486
- [TS migration] Follow up on improving the form #36532
- Fix: Wrong referral link after updating primary contact #36556
- Display deleted request in transaction thread report #36557
- Show keyboard shortcuts page modal wherever you are in the app #36559
- [Audit][Implementation] getOrderedReportIDs - cache removal #36565
- fix: Chat - Font size is smaller in single backtick code block. #36568
- fix logic get year #36590
- Fix/35945: Selected category is not highlighted #36596
- Fix: Login - Expensify logo is too close to the top of the screen #36626
- feat: display members(admin) and profile only for collect group policy #36672
- Add missing params in vbba setup flow and clean up #36689
- Create Set-notifications.md #36698
- Create Manage-devices.md #36700
- fix: Set tag, category, and billable when editing a split bill #36759
- Update broken link in docs #36760
- Request location only when necessary in MapView #36761
- Fix: Empty state image has too much overlap with message in attachment thread #36765
- Fix saved reportField values #36769
- disable iOS bounce on private notes page #36772
- fix strikethrough line is white on links and emails #36773
- bump onfido native sdk version #36783
- chore: move policy tax rates to policy key #36784
- fix: The list of users in mentions does not disappear when using the Shift+Enter #36792
- [Update Account Settings] Fix Wallet Page default badge style #36794
- update sign in page structure #36803
- [Ideal nav v2] Update Share code and Status buttons #36805
- Fix/34900: Dms show up twice #36816
- Update Expensify-Playbook-For-Small-To-Medium-Sized-Businesses.md #36817
- Fix client side tag violations and Improve function signatures #36821
- Fix workspace item isn't highlighted when navigating with arrow key #36839
- Fix money request draft amount isn't cleared when reopening the page #36845
- Fix: When a user is mentioned, a sound is triggered. However, the current implementation plays the sound regardless of who is mentioned. #36848
- Handle translations in hold money request workflow #36851
- Fix infinite loading when opening a workspace page after login #36852
- [NoQA] LocaleCompare util tests #36879
- Fix a next step when reimbursing #36880
- [TS migration] Migrate 'androidReversePort.js' test to TypeScript #36895
- [No QA][TS migration] Migrate 'writeTestStats.js' test to TypeScript #36896
- [No QA][TS migration] Migrate 'isStagingDeployLockedTest.js' test to TypeScript #36897
- Implement control playback speed #36898
- Add Share page for Workspace Profile #36907
- fix: Chat - Download option in three-dot menu is still available in offline mode #36918
- [No QA] [TS migration] Migrate 'execAsync.js' test to TypeScript #36922
- [Re-fix]: "Invite a friend" banner do not move up when input field is focused in search page #36931
- [No QA] fix: Storybook stuck loading #36939
- [Audit][Implementation] Replace localeCompare with static Collator implementation #36941
- Update redirects.csv #36943
- Fix - LHN - When you delete a message from a room, the conversation in the members remains bolded #36950
- fix: prevent the soft keyboard from showing when the composer is not visible #36953
- Rename Invite-Members.md to Invite-Members.md #36962
- Fix system paid message #36993
- Fix: disabled tag is not displayed in the list as selected #36994
- Fix blank screen is shown when opening a report screen after relaunching app #36996
- Mention: prioritize displayName over login #36998
- Fix not found title text doesn't animate when keyboard is closed (iOS) #36999
- #35712 selection list refactor #37000
- [NoQA] dev: improve e2e tests DX #37008
- IOU: use cleared pending fields #37009
- Update customUnit and customUnitRate types #37023
- Fix: confirm button not disabled when offline in VBBA flow #37025
- Use RadioListItem in StatusClearAfterPage #37028
- Fix: Bank Account page scrolls to the top of the page when pressed on a field #37032
- Amount selection fix #37041
- fix: Split Bill - Group members disappeared in a split bill when make second split bill in a row #37048
- Never show 'You manually marked this report as reimbursed' message on NewDot. #37051
- fix: BA - No validation error when emoji and certain symbols are entered in name field #37052
- [No QA] make
.github/workflows/failureNotifier.ymlgenerate a hourly issue instead of a daily one #37055 - Update redirects.csv #37056
- [No QA] Run pod install if node_modules changed #37059
- Fix ts error #37063
- Fix irrelevant chat is shown when using workspace filtered chats #37068
- Fix: Crash when opening iou category picker page. #37072
- Feature/35712 redesign of members list #37074
- Fix pressing ESC closes both video player popover and the attachment preview #37077
- Remove the usage of
Array.prototype.toSorted#37078 - [HybridApp] Add patch for
expo-avrequired to run HybridApp #37079 - feat: swipe down to close #37080
- [No QA][TS migration] Migrate 'Alert' component to TypeScript #37086
- Remove heading style from text #37087
- [No QA] Clarify threshold to add new lib #37097
- Connect Bank Account - No limit for entering amount in transition field #37106
- [NoQA] Use preventSelfApprovalEnabled policy prop to match db format #37112
- #37096 translation and subtitle color #37123
- fix: Domain name is not dropped when sending text with user mention #37132
- Expose Onyx.get to window for easier debugging #37138
- Fixes for feature: Add support for redirecting user to a target URL when they click on the magic link code #37145
- fix: broken search screen on Android #37155
- [No QA] Fix failing TS on main #37171
- [No QA] Create Onyx.log debugging utility #37172
- feat: Remove Add receipt from the three dot overflow menu. #37178
- [No QA] Fix type errors in AvatarWithImagePicker and WorkspaceProfilePage #37186
- Fix hasRouteMatchingPolicyID #37201
- Revert "[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript" #37218
- [CP Staging] Fix/37253: Console log error when opening thread #37261
- revert: native stack #37305
- fix: logic get sign index suggestion mention #37308
- fix: Condition for disabling currency for workspace was wrong #37320
- Fix unable to add the file that is not image #37322
- fix blocker where we incorrectly navigate to concierge chat when creating a new room #37323
- Revert "fix/35934 | Workspaces - Сustom avatar is applied to all workspace rooms" #37330
- fix: Recalculate the sections only on actual change #37341
- Fix bug with Selected bank account is not checked in bank account selection step #37342
- [Categories] Add support for long category names #37389
- Get correct default category for split scan request #37392
- fix: Bank account icon is a green square #37450
- Revert 31606 #37454
Internal QA:
- [Android|iOS] overwrite system sound for push notifications via a custom one #36807 -
- remove unnecessary concierge check #35439 - @blimpich
Deploy Blockers:
- [HOLD for payment 2024-03-07] [$500] Workspaces - Сustom avatar is applied to all workspace rooms #35934
- [$500] Changing playback speed is not taking effect when changing playback speed before playing #36827
- [PAID] [$500] Video - Two different crashes occur when downloading video #36833
- [HOLD for payment 2024-03-15] [$500] Expense - App crashes when changing date, description, merchant of the request #36857
- [$500] Distance - Total amount in report is not reset to 0.00 when changing distance request offline #36892
- [$500] IOU - Total paid amount instead of individual amount is copied from each paid IOU preview #36924
- [HOLD for payment 2024-03-07] [$500] Room - User is navigated to Concierge report when creating room #37234
- [$500] Invite members - blank row is displayed when removing user in offline mode #37235
- [HOLD for payment 2024-03-14] [$500] Task - Pointer shows up for an archived task when hovering over the edge of the checkbox #37236
- [HOLD for payment 2024-03-07] [$500] IOU - "To" destination is highlighted in confirmation page #37238
- [$500] Workspace switcher - Both "Expensify" and another workspace are highlighted in WS switcher #37239
- [HOLD for payment 2024-03-07] [HOLD for payment 2024-03-06] [$500] Android - Chat - Unable to upload pdf file #37240
- [HOLD for payment 2024-03-29] [$500] [MEDIUM] Categories: "Parent" that does not have individual category is not grayed out #37241
- [$500] IOU - Request details page loads infinitely when request is created offline #37247
- [HOLD for payment 2024-03-14] [$250] iOS - Image - Maximum zoom is applied after zooming out #37248
- [HOLD for payment 2024-04-15] [$500] iOS - Video - User needs to tap on play button twice for the video to restart #37249
- [HOLD for payment 2024-03-07] [$500] Chat - The selected 2nd contact is shown in first line #37250
- [$500] Chat - Loading is displayed when the user opens a new contact page 1:1 #37251
- [HOLD for payment 2024-03-07] Android - Task-Tapping assignee shows infinite loading page #37252
- [HOLD for payment 2024-03-07] [$125] Web - Thread - Console error shows up when opening message in thread #37253
- [$500] Android - IOU - In WS, opening paid IOU details page shows hhm not here #37255
- [HOLD for payment 2024-03-07] [$500] Group - After selecting user in Group chat, the modal is not sliding upwards #37256
- [HOLD for payment 2024-03-07] [$500] IOU - Keyboard comes out from right to left on participant screen #37257
- [$500] Chat - Incorrect search result & Show More' Dropdown shown when one search result displayed #37267
- [$500] iOS - After disabling internet connection, Concierge chat renames to concierge@expensify.com #37268
- [$500] Bank account - Error flickers when trying to add bank account after deleting previous one #37271
- [HOLD for payment 2024-03-07] [$500] Android - Task - Keyboard does not open after selecting task title #37273
- [$500] Android - IOU-Tapping hold request, cursor is shown but keypad is not opened #37279
- [$500] Category - The first item in the Category list is not highlighted by default #37284
- [HOLD for payment 2024-03-22] [$500] Category - Selected category is not ticked when it appears in the search result #37287
- [HOLD for payment 2024-03-07] [$500] Workspace - Default currency is clickable as a workspace member and it leads to error page #37288
- [HOLD for payment 2024-03-22] [$500] Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu #37289
- [HOLD for payment 2024-03-07] [$500] Bank account - Selected bank account is not checked in bank account selection step #37290
- [$500] iOS - Log out - App flashes briefly when logging out #37291
- [HOLD for payment 2024-03-14] [$500] Hold Request - English content is copied to clipboard when hold request message is Spanish #37292
- [HOLD for payment 2024-03-11] [$500] Workspace - The selection is smaller than member name row when navigating via keyboard #37293
- [$500] Expense - Unable to save Merchant by hitting Enter in confirmation page #37294
- [HOLD for payment 2024-04-03] [$500] Workspace - Member and Role can be clicked to select all the members in Members list #37295
- [$500] Scan - Expense report and transaction report are no longer hidden in LHN when scanning fails #37296
- [HOLD for payment 2024-03-07] [$500] [MEDIUM] Categories: Long category name is displayed in one line instead of two lines #37297
- [$500] Mark down - Email with strikethrough is not underlined #37299
- Web - IOU - There is a delay in sending money #37300
- [$500] iOS - Settings - The keyboard appears with a black background that changes to grey #37301
- [HOLD for payment 2024-03-07] [$500] Android - Wallet - The keyboard does not open automatically when the debit card is opened #37325
- [HOLD for payment 2024-03-20] [$500][MEDIUM] Categories: Parent that has own category is not ticked in All list when selected #37326
- [$500] Category - Narrow spacing between search field and "Recent" header #37328
- [$500][MEDIUM] Categories: Search field is present in category list when there are fewer than 8 categories to choose from #37329
- [HOLD for payment 2024-03-29] [$500] Web - Chat - Infinite spinner in ND when navigating from OD in different ways #37332
- [HOLD for payment 2024-03-07] [HOLD][$500] [MEDIUM] Tags: All tags are revealed when searching for hidden tag and clearing the search field #37335
- [HOLD for payment 2024-03-11] [$500] Login - Two offline indicators in login screen #37336
- [$500] IOU - Message doesn't contain description when Copy to clipboard on money request #37338
- [$500] Distance - EReceipt thumbnail is not clickable when distance request is edited offline #37344
- [HOLD for payment 2024-03-07] [$500] Category - Selected category does not appear as selected in split request Category list #37346
- [$500] Login - Infinite loading when login via Abracadabra page #37351
- [$500] Web - Workflows - After the page refreshes, the switch returns to the default value #37363
- [HOLD for payment 2024-04-05] [$500] Workflows-If the first 2 options are enabled,cannot scroll to see the 3th option #37403
- [$500] Settings - The classicRedirect->dismissedReason displays the first response #37408
- [$500] Workspace settings - The list of categories is empty after Relogin #37409
- [HOLD App#36948][$500] Windows - Settings - The textbox isn't auto focused #37410
- [HOLD for payment 2024-03-07] [$500] Wallet - Bank account icon is a green square #37413
- [HOLD for payment 2024-03-14] [$500] Category - No spacing between long category name and category status #37417
- [$500] Web - Workspace - It's not accepting the SSN for the first time #37442
- [HOLD for payment 2024-04-05] [$500] Category - The second line of long subcategory is not indented #37444
- [$500] Category - Long category name pinned to the left margin and not has indented #37446
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Feb 26, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.44-0 🚀
luacmartins commentedon Feb 26, 2024
Checking off #37235. Dupe of #37109
roryabraham commentedon Feb 26, 2024
Demoted #37239
youssef-lr commentedon Feb 27, 2024
Checking off #37248, I can reproduce in production.
techievivek commentedon Feb 27, 2024
#37253 is resolved.
Julesssss commentedon Feb 27, 2024
I checked off #36807 from the internal QA list 🎉
melvin-bot commentedon Feb 27, 2024
Julesssss commentedon Feb 27, 2024
I'm not sure who checked off #37291, but it is definately not a blocker
melvin-bot commentedon Feb 27, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
kavimuru commentedon Feb 27, 2024
Regression is 7% left. We are still working on the PRs.
#34409 is failing in mweb with #37276 and repro in PROD, checking if off
#35065 failing with #37252 in android
#35451 is failing with known bug #32699.checking it off. Please see comment #35451 (comment)
rlinoz commentedon Feb 27, 2024
Demoted #37279
3 remaining items
chiragsalian commentedon Feb 27, 2024
QA team, we CP-d this PR #37305. Since its a revert there is nothing to to test directly with that PR.
Instead can you retest its linked issues, they are all deploy blockers and if the issue is resolved please clear the deploy blocker labels,
#37257
#37252
#37273
#37156
#37325
kavimuru commentedon Feb 27, 2024
@chiragsalian Sure we will retest and remove the blocker labels.
melvin-bot commentedon Feb 27, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
kavimuru commentedon Feb 27, 2024
Regression is left with 5 steps. We are still validating the PRs.
Unchecked PRs:
#35065 failing with #37252 in android
#36773 failing with #37229
#37009 failing with #37247
@puneetlath
QA team does not have physical card to validate this PR #34716 (comment) - It would be great if you could verify this internally.
I think the following PRs does not require QA. Could you confirm?
#36321 (comment)
#36323 (comment)
#36466 (comment)
puneetlath commentedon Feb 27, 2024
Confirmed.
kavimuru commentedon Feb 27, 2024
@chiragsalian
All the bugs are not repro anymore. Removing deployblocker label.
kavimuru commentedon Feb 28, 2024
Regression TR completed. We have few PR and CPs are yet to be validated.
#35065 failing with #37252 in android
#35451 is failing with known bug #32699.checking it off. Please see comment #35451 (comment)
#36773 failing with #37229
#36759 and #37009 failing with # 37247
#35319 failing with known bug #27866 in mweb. checking it off. see comment #35319 (comment)
#36345 failing with #37363
Julesssss commentedon Feb 28, 2024
Checking off #37403 as it isn't a blocker.
kavimuru commentedon Feb 28, 2024
#35065 failing with #37252 in android
#36773 failing with #37229
#36759 and #37009 failing with # 37247
#36345 failing with #37363
#36993 failing with #37338
#35449 failing with #37405 repro in PROD checking it off
#36784 failing with #37414
#36848 failing with #37434 repro in PROD checking it off
puneetlath commentedon Feb 28, 2024
Checking off #36345. It'll be fixed as a follow-up not blocking the deploy.
puneetlath commentedon Feb 28, 2024
Checking off #37408 since it's likely a back-end thing.
puneetlath commentedon Feb 28, 2024
Marking #37417 as not a blocker.
puneetlath commentedon Feb 28, 2024
Decided #37271 is not a blocker here.
puneetlath commentedon Feb 28, 2024