fix: Split Bill - Group members disappeared in a split bill when make second split bill in a row by adriancova · Pull Request #37048 · Expensify/App

adriancova · 2024-02-21T20:49:22Z

Details

Removing transaction draft merge to null on success and failure to prevent ui resetting while user is editing a new draft.

Fixed Issues

$ #33518
PROPOSAL: #33518 (comment)

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

Same as QA steps.

QA Steps

Create a group chat
Send a split bill
Immediately after try to send a new one, issue used to be that it would get reset but now instead it's showing a loading screen. (which should no longer be the case with this fix, instead the ui should not get reset/loading screen)
(Best way to reliably reproduce the issue is to throttle the network requests)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb.android.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb.iphone.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-02-21T20:49:27Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-02-21T20:49:39Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

adriancova · 2024-02-21T20:51:41Z

I have read the CLA Document and I hereby sign the CLA

adriancova · 2024-02-21T20:52:08Z

recheck

abdulrahuman5196

@adriancova

Kindly remove the draft from failureData as mentioned here as well. It should fix other issue as well

#35064 (comment)

Sign in to view

            key: `${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransaction.transactionID}`,
            value: {pendingAction: null},
        },
-        {


adriancova · 2024-02-22T15:26:10Z

ready @abdulrahuman5196 , optimistic draft was removed from failure and success data, and added instead to optimistic data.

…n optimisticData

abdulrahuman5196 · 2024-02-23T15:46:32Z

@adriancova

Kindly remove the draft from failureData as mentioned here as well. It should fix other issue as well

#35064 (comment)

@adriancova This comment isn't addressed yet. Could you kindly add this?

adriancova · 2024-02-23T16:05:54Z

Hi @abdulrahuman5196, yes sorry I see now which one you meant. Should be good now, let me know if there'd be anything pending from my side.

abdulrahuman5196 · 2024-02-23T18:51:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-24.at.12.11.10.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-02-24.at.12.16.32.AM.mp4

iOS: Native

Screen.Recording.2024-02-24.at.12.05.10.AM.mp4

iOS: mWeb Safari

Screen.Recording.2024-02-24.at.12.07.13.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-23.at.11.57.11.PM.mp4

MacOS: Desktop

Screen.Recording.2024-02-24.at.12.01.57.AM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @dangrous

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2024-02-23T19:04:04Z

Kindly run the workflows before approval since it needs a maintainer to run them.

dangrous

cool, I think this makes sense to me and workflows look good!

OSBotify · 2024-02-23T21:29:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:10:50Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:59:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2024-11-24T13:22:57Z

+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`,
+            value: null,
+        },


Clearing the draft here is executed too early; before the user finishes the split flow (before navigation) which resulted in UI briefly showing stale data

Coming from #52196

Remove TRANSACTION_DRAFT merge to null from successData and failureData

6539262

adriancova requested a review from a team as a code owner February 21, 2024 20:49

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team February 21, 2024 20:49

abdulrahuman5196 suggested changes Feb 22, 2024

View reviewed changes

Comment thread src/libs/actions/IOU.ts

key: `${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransaction.transactionID}`,

value: {pendingAction: null},

},

{

This comment was marked as outdated.

Sign in to view

adriancova added 2 commits February 22, 2024 09:20

adding back merge to null for failure data

befeda9

adding back merge to null for optimistic* data

7b43b0d

adriancova requested a review from abdulrahuman5196 February 22, 2024 15:24

removed transaction_draft set to null in failureData since its done i…

73e4b6c

…n optimisticData

abdulrahuman5196 approved these changes Feb 23, 2024

View reviewed changes

melvin-bot Bot requested a review from dangrous February 23, 2024 19:03

dangrous approved these changes Feb 23, 2024

View reviewed changes

dangrous merged commit 2ec696e into Expensify:main Feb 23, 2024

github-actions Bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

adriancova deleted the issue-33518 branch May 15, 2024 01:03

s77rt reviewed Nov 24, 2024

View reviewed changes

s77rt mentioned this pull request Nov 24, 2024

[HOLD for payment 2024-11-26] [$250] Distance - After tapping split expense with amount button, briefly "split expense" button shown #52196

Closed

1 of 8 tasks

Conversation

adriancova commented Feb 21, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 21, 2024

Uh oh!

github-actions Bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adriancova commented Feb 21, 2024

Uh oh!

adriancova commented Feb 21, 2024

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

adriancova commented Feb 22, 2024

Uh oh!

abdulrahuman5196 commented Feb 23, 2024

Uh oh!

adriancova commented Feb 23, 2024

Uh oh!

abdulrahuman5196 commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Feb 23, 2024

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 23, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

s77rt Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Feb 21, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 23, 2024 •

edited

Loading