Skip to content

fix: Split Bill - Group members disappeared in a split bill when make second split bill in a row #37048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangrous merged 4 commits into from
Feb 23, 2024
Merged

fix: Split Bill - Group members disappeared in a split bill when make second split bill in a row #37048

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6539262
Remove TRANSACTION_DRAFT merge to null from successData and failureData
adriancova Feb 20, 2024
befeda9
adding back merge to null for failure data
adriancova Feb 22, 2024
7b43b0d
adding back merge to null for optimistic* data
adriancova Feb 22, 2024
73e4b6c
removed transaction_draft set to null in failureData since its done i…
adriancova Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,14 +614,6 @@ function buildOnyxDataForMoneyRequest(
pendingFields: null,
},
},

// Remove the temporary transaction used during the creation flow
{
onyxMethod: Onyx.METHOD.SET,
key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`,
value: null,
},

{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport?.reportID}`,
Expand Down Expand Up @@ -1605,6 +1597,11 @@ function createSplitsAndOnyxData(
key: `${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransaction.transactionID}`,
value: splitTransaction,
},
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`,
value: null,
},
Comment on lines +1600 to +1604

@s77rt s77rt Nov 24, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing the draft here is executed too early; before the user finishes the split flow (before navigation) which resulted in UI briefly showing stale data

Coming from #52196

];

const successData: OnyxUpdate[] = [
Expand All @@ -1621,11 +1618,6 @@ function createSplitsAndOnyxData(
key: `${ONYXKEYS.COLLECTION.TRANSACTION}${splitTransaction.transactionID}`,
value: {pendingAction: null},
},
{

This comment was marked as outdated.

Sign in to view

onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`,
value: null,
},
];

if (!existingSplitChatReport) {
Expand All @@ -1644,11 +1636,6 @@ function createSplitsAndOnyxData(
errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),
},
},
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`,
value: null,
},
];

if (existingSplitChatReport) {
Expand Down