Repository navigation
IOU-"Enter a merchant name"error shown for amount in split bill scan. #37473
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Action Performed:
- Launch app
- Tal on Workspace chat
- Tap plus icon near compose
- Tap split bill--- Scan
- Using camera upload a photo
- Tap split
- Open the newly created split scan expense
- Note amount field error
Expected Result:
"Enter an amount"error must be shown for amount in split bill scan.
Actual Result:
"Enter a merchant name"error shown for amount in split bill scan.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Feb 29, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 29, 2024
Triggered auto assignment to @danieldoglas (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Feb 29, 2024
We think that this bug might be related to #vip-bills
izarutskaya commentedon Feb 29, 2024
@danieldoglas I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
bernhardoj commentedon Feb 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The merchant error is shown for the amount field.
What is the root cause of that problem?
This is coming from this commit where we put merchant error for amount error.
What changes do you think we should make in order to solve the problem?
Revert the commit changes by using the amount error.
youssef-lr commentedon Feb 29, 2024
cc @kubabutkiewicz we think this might be coming from your PR #34168
kubabutkiewicz commentedon Feb 29, 2024
taking a look 👀
kubabutkiewicz commentedon Feb 29, 2024
#37515 PR ready @youssef-lr
melvin-bot commentedon Feb 29, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
puneetlath commentedon Feb 29, 2024
FYI, this is likely fixed by this revert. Will have QA re-test once it is CP'd.
puneetlath commentedon Feb 29, 2024
Looks like the revert fixed this.