[HOLD for payment 2024-08-07] [$500] Onyx updates are not being queued in the correct order

@paultsimura

Problem

When batching update operations (e.g. when coming online), Onyx executes the merge and mergeCollection operations in an incorrect order which leads to data inconsistency. See this comment for context.

Why do we care?

This has caused multiple issues: this, this, and is currently holding this.

What's expected?

The updates should happen in the same exact order as they've been enqueued to guarantee the eventual consistency of the data.

Note: this will probably involve working with the react-native-onyx repository

Issue reported by: @paultsimura
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1709229991663269?thread_ts=1705484273.717249&cid=C01GTK53T8Q

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fec4289917eb6d71
Upwork Job ID: 1763289951731056640
Last Price Increase: 2024-02-29
Automatic offers:

jjcoffee | Reviewer | 0
paultsimura | Contributor | 0

Issue Owner

Current Issue Owner: @Christinadobrzyn

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01fec4289917eb6d71

@jjcoffee

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@jjcoffee

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@paultsimura

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Reviewing label has been removed, please complete the "BugZero Checklist".

@paultsimura

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Bump Onyx to 2.0.57 #46297

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment automatic offer (Contributor)
@jjcoffee requires payment automatic offer (Reviewer)
@paultsimura requires payment automatic offer (Contributor)

@paultsimura

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@paultsimura] The PR that introduced the bug has been identified. Link to the PR:
[@paultsimura] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@paultsimura] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@paultsimura] Determine if we should create a regression test for this bug.
[@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/418518

@paultsimura

Payouts due:

Contributor: $500 @paultsimura (Paid in Upwork - https://www.upwork.com/nx/wm/offer/101149714)

Do we need a regression test @paultsimura?

@Christinadobrzyn

Sorry @Christinadobrzyn, this one is $500, not $250 as mentioned in the payment summary.

I was not a C+ here, but would suggest the regression test:

Submit a distance request with 3 waypoints
Navigate to the distance request details (transaction thread)
Disable the internet connection
Click on the distance field to edit
Click on a waypoint
Click on the 3 dot menu > Delete waypoint
Hit Save
Switch chat
Go back online
Go back to the transaction thread
Click "distance" again
Verify the deleted waypoint is not present (i.e. it's "indeed" deleted)

@Christinadobrzyn

@Christinadobrzyn No payment due to me as I never reviewed anything in the end 🙏

@paultsimura

Thanks @paultsimura and @jjcoffee - are we paying someone else? @sobitneupane I see you on the PR, were you the C+ for this?

@tgolen

Technically, there was no C+ here, only me and @tgolen mostly.

@paultsimura

Ah okay! Thanks @paultsimura!

I paid this out based on this payment summary. The regression test is created so I think this is good to close. Let me know if I'm missing anything!

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-07] [$500] Onyx updates are not being queued in the correct order #37560

Problem

Why do we care?

What's expected?

66 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-07] [$500] Onyx updates are not being queued in the correct order #37560

Description

Problem

Why do we care?

What's expected?

Activity

melvin-bot commented on Feb 29, 2024

melvin-bot commented on Feb 29, 2024

melvin-bot commented on Feb 29, 2024

melvin-bot commented on Feb 29, 2024

melvin-bot commented on Feb 29, 2024

66 remaining items

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

Christinadobrzyn commented on Aug 6, 2024

paultsimura commented on Aug 7, 2024

paultsimura commented on Aug 7, 2024

jjcoffee commented on Aug 7, 2024

Christinadobrzyn commented on Aug 7, 2024

paultsimura commented on Aug 7, 2024

Christinadobrzyn commented on Aug 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions