[HOLD for payment 2024-04-09] [$500] Workspace - New Workspace button doesn't create WS and shows no default name

@alitoshmatov

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.53-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory around https://expensify.testrail.io/index.php?/tests/view/4428235
Issue reported by: Applause - Internal Team

Action Performed:

Go to NewDot and login
Click WS dropdown in the top of LHN
Click +
Change WS name and click Save
Click New Workspace button in the top right corner

Expected Result:

New WS created, default name should be displayed

Actual Result:

Default name is not displayed, and WS is not created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6415317_1710529817272.video_32.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0171b0f044271b7cff
Upwork Job ID: 1769593725439668224
Last Price Increase: 2024-03-18
Automatic offers:

alitoshmatov | Reviewer | 0

Issue Owner

Current Issue Owner: @alitoshmatov

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kadiealexander

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Fix opening RHP in FullScreenNavigator

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace lists page opens up when trying to update workspace name, currency etc after creating a new workspace.

What is the root cause of that problem?

We shouldn't be seeing the workspaces list when editing the newly created workspace name.

This logic is unnecessarily pushing the workspaces list page in the central pane.

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 185 to 189 in e40fba1

    
           // When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane. 
        
           // Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane. 
        
           if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) { 
        
               routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES})); 
        
           }

What changes do you think we should make in order to solve the problem?

There's no need of the above logic, we can simply remove it and it will solve the navigation issue. Same issue can be seen at multiple other places which will also get resolved.

This is same as my proposal here: #38436 (comment)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We have a logic added from #37421 Ideal Nav PR which sets the Central Pane to Workspace settings page

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 185 to 189 in e40fba1

    
           // When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane. 
        
           // Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane. 
        
           if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) { 
        
               routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES})); 
        
           }

This was done to address the condition where RHP was opened from FullScreenNavigator, to adjust to the correct page of central pane.

But over here we only consider the condition when RHP was opened from LHN and not the condition where RHP is opened from Central Pane.

What changes do you think we should make in order to solve the problem?

We need to consider an additional Condition to check if the RHP was opened from LHN and then only Set the Central Pane to workspace settings Page:

- if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
+ if ((matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) && isRHPScreenOpenedFromLHN) {
                routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
            }

What alternative solutions did you explore? (Optional)

N/A

Job added to Upwork: https://www.upwork.com/jobs/~0171b0f044271b7cff

@WojtekBoman

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix opening FullScreenNavigator from the Home page #38734

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

@WojtekBoman does not require payment (Contractor)
@alitoshmatov requires payment automatic offer (Reviewer)

@alitoshmatov

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
[@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@alitoshmatov] Determine if we should create a regression test for this bug.
[@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@alitoshmatov

$500 to @alitoshmatov

@alitoshmatov

@alitoshmatov please don't forget about the checklist!

@alitoshmatov

Bumped @alitoshmatov here.

The PR that introduced the bug has been identified. Link to the PR: [Wave 8] Ideal nav #33280
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33280/files#r1561250597
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. No need

@alitoshmatov

Payouts due:

Contributor+: $500 @alitoshmatov

Upwork job is here.

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-09] [$500] Workspace - New Workspace button doesn't create WS and shows no default name #38420

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

43 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane.
	// Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane.
	if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
	routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
	}

[HOLD for payment 2024-04-09] [$500] Workspace - New Workspace button doesn't create WS and shows no default name #38420

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 15, 2024

lanitochka17 commented on Mar 15, 2024

lanitochka17 commented on Mar 15, 2024

HezekielT commented on Mar 16, 2024

ShridharGoel commented on Mar 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

allgandalf commented on Mar 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Mar 18, 2024

43 remaining items

melvin-bot commented on Apr 2, 2024

melvin-bot commented on Apr 2, 2024

mountiny commented on Apr 2, 2024

kadiealexander commented on Apr 3, 2024

kadiealexander commented on Apr 11, 2024

alitoshmatov commented on Apr 11, 2024

kadiealexander commented on Apr 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions