Background changes to workspace when changing the workspace name

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.53-2
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

Create a workspace from "Choose a workspace"
Now click on workspace name
Notice background changed

Expected Result:

The background should not change when RHN open

Actual Result:

Background changes to workspace when changing the workspace name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6415760_1710574375920.2024-03-16_12-18-33.mp4

View all open jobs on GitHub

@miljakljajic

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@miljakljajic

@miljakljajic I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace lists page opens up when trying to update workspace name, currency etc after creating a new workspace.

What is the root cause of that problem?

This logic is unnecessarily pushing the workspaces list page in the central pane.

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 185 to 189 in e40fba1

    
           // When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane. 
        
           // Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane. 
        
           if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) { 
        
               routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES})); 
        
           }

What changes do you think we should make in order to solve the problem?

There's no need of the above logic, we can simply remove it and it will solve the navigation issue. Same issue can be seen at multiple other places which will also get resolved.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We have a logic added from #37421 Ideal Nav PR which sets the Central Pane to Workspace settings page

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 185 to 189 in e40fba1

    
           // When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane. 
        
           // Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane. 
        
           if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) { 
        
               routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES})); 
        
           }

This was done to address the condition where RHP was opened from FullScreenNavigator, to adjust to the correct page of central pane.

But over here we only consider the condition when RHP was opened from LHN and not the condition where RHP is opened from Central Pane.

What changes do you think we should make in order to solve the problem?

We need to consider an additional Condition to check if the RHP was opened from LHN and then only Set the Central Pane to workspace settings Page:

- if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
+ if ((matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) && isRHPScreenOpenedFromLHN) {
                routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
            }

What alternative solutions did you explore? (Optional)

N/A

Dropping proposal here too.

But i think this issue is related to #38420 and should be either closed or put on hold

I agree that we can close in favour of #38420

Navigation Menu

Repository navigation

Background changes to workspace when changing the workspace name #38436

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane.
	// Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane.
	if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
	routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
	}

Background changes to workspace when changing the workspace name #38436

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 16, 2024

kbecciv commented on Mar 16, 2024

ShridharGoel commented on Mar 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

allgandalf commented on Mar 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allgandalf commented on Mar 17, 2024

miljakljajic commented on Mar 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions