Repository navigation
Wallet - Back button in Wallet loops between Wallet and Add bank account #39847
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #39038
Action Performed:
- Launch New Expensify app
- Paste the link https://staging.new.expensify.com/settings/wallet/add-bank-account-refactor
in chat - Tap on the link
- Tap on the back button
- Tap on the back button again
Expected Result:
After tapping on the back button in Wallet page, app will redirect to settings page
Actual Result:
Back button in Wallet page loops between Wallet and Add bank account page after navigating to https://staging.new.expensify.com/settings/wallet/add-bank-account-refactor
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Apr 8, 2024
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 8, 2024
@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
AndrewGable commentedon Apr 8, 2024
Tagging those involved in #39038: @koko57 @barttom @ArekChr @rezkiy37 @shawnborton @Pujan92 @mountiny
Can you see if this regression is related? Thanks
Pujan92 commentedon Apr 8, 2024
Yes, it is related to linked PR. @koko57 I think we should not pass any fallback route for
goBackas that pattern I am seeing at other places.App/src/pages/EnablePayments/AddBankAccount/AddBankAccount.tsx
Line 67 in 6ec5811
As this flow is not open to user yet, we can remove deploy blocker for this.
AndrewGable commentedon Apr 8, 2024
Just to confirm @Pujan92 - It's under a beta? Or what do you mean by "As this flow is not open to user yet"?
Pujan92 commentedon Apr 8, 2024
Actually, this wallet refactor is still in progress and at the moment the users are navigated to the old flow only(where this issue doesn't persist). New flow navigation will be replaced with the old one once all the steps of refactoring are completed.
koko57 commentedon Apr 8, 2024
@AndrewGable the refactor is still work in progress and all the issues will be resolved in the following PRs.
3 remaining items
mountiny commentedon Apr 8, 2024
I can take over and monitor with @koko57 its part of #36648 and the flow is behind specific route, we will address this in the follow up PRs before we enable the flow for actual users
mountiny commentedon Apr 16, 2024
Making this monthly as the refactor is ongoing
mountiny commentedon May 20, 2024
The refactor should be done soon, last PR remaining
mountiny commentedon Jun 24, 2024
the refactor is done. @lanitochka17 could you please retest if this issue is still repro?
kavimuru commentedon Jun 24, 2024
@mountiny Bug is fixed.
Screen_Recording_20240624_230040_New.Expensify.mp4
mountiny commentedon Jun 24, 2024
🎉