Repository navigation
[HOLD for payment 2024-04-25] Expense - GBR appears briefly in LHN when Schedule submit is enabled and admin requests money #39923
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #38675
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
- Go to staging.new.expensify.com
- Create a new Collect workspace.
- Go to Profile > Workspaces > Collect workspace.
- Go to More features > Enable workflows.
- Go to Workflows.
- Enable Add approvals.
- Also please ensure that "Delay submissions" is enabled.
- Return to workspace chat.
- Create a manual request.
Expected Result:
Since "Schedule submit" is enabled in Step 7, there should be no GBR in LHN when admin requests money from the workspace chat.
Actual Result:
When admin requests money from the workspace chat, GBR appears for a while, then disappears.
This issue only happens when admin requests money from the workspace chat, not when employee requests money from the workspace chat.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Apr 9, 2024
Triggered auto assignment to @arosiclair (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 9, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Apr 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 9, 2024
@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 9, 2024
We think this issue might be related to the #collect project.
paultsimura commentedon Apr 9, 2024
Looks like a regression from my PR, checking now 👀
paultsimura commentedon Apr 9, 2024
@mountiny could you please help me clarify the requirements a bit? These GBR branches are a bit complicated, and we've gone through a couple of them with you on the original PR.
Am I correct to assume the following?
9 remaining items
paultsimura commentedon Apr 9, 2024
The PR's ready: #39941
cc: @mountiny @akinwale
mountiny commentedon Apr 9, 2024
Actually as I was writing the request to cherry pick I think this does not have to be CPed its a minor bug that wont really influence users so we can leave this go with the normal process
mountiny commentedon Apr 9, 2024
I have created an issue here to internally handle that clean up as I think we need to make this logic slightly more robust and it will be easier if internal person handles it #39953
mountiny commentedon Apr 9, 2024
I believe we can close this now
[-] Expense - GBR appears briefly in LHN when Schedule submit is enabled and admin requests money[/-][+][HOLD for payment 2024-04-25] Expense - GBR appears briefly in LHN when Schedule submit is enabled and admin requests money[/+]melvin-bot commentedon Apr 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: