[Re-test] Workspace - "Hmm it's not here" message appears briefly when changing tags

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.72.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41723

Action Performed:

Preconditions: Have a Collect WS with Tags and Taxes enabled. Have at least one tag added

Log in with an expensifail account
Navigate to FAB - Send invoice
Finish the invoice flow
Open the invoice details
Change the tag

Expected Result:

No error should be visible

Actual Result:

"Hmm it's not here" message appears briefly when changing tags

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6475607_1715241293798.REBW6051.mp4

View all open jobs on GitHub

@strepanier03

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@strepanier03

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Hmm it's not here" message appears briefly when changing tags

What is the root cause of that problem?

For the invoice report, we move to this case and update the iouReport in IOUUtils.updateIOUOwnerAndTotal

App/src/libs/actions/IOU.ts

Line 2398 in 0e8a10d

    
           updatedMoneyRequestReport = IOUUtils.updateIOUOwnerAndTotal(iouReport, updatedReportAction.actorAccountID ?? -1, diff, TransactionUtils.getCurrency(transaction), false, true);

In here we have the logic to swap managerAccountID and ownerAccountID when the total < 0. But for invoice report, the total is always <0 so the managerAccountID is changed to the current user

App/src/libs/IOUUtils.ts

Lines 88 to 92 in 0e8a10d

    
           if (iouReportUpdate.total < 0) { 
        
               // The total sign has changed and hence we need to flip the manager and owner of the report. 
        
               iouReportUpdate.ownerAccountID = iouReport.managerID; 
        
               iouReportUpdate.managerID = iouReport.ownerAccountID; 
        
               iouReportUpdate.total = -iouReportUpdate.total;

And then not found page appear briefly by this condition

App/src/libs/ReportUtils.ts

Lines 2597 to 2599 in 0e8a10d

    
           if (isInvoiceReport(moneyRequestReport) && isManager) { 
        
               return false; 
        
           }

App/src/pages/iou/request/step/IOURequestStepTag.tsx

Line 83 in 0e8a10d

    
           const shouldShowNotFoundPage = !shouldShowTag || (isEditing && (isSplitBill ? !canEditSplitBill : reportAction && !canEditMoneyRequest(reportAction)));

What changes do you think we should make in order to solve the problem?

I think invoice report is similar with expense report, we should add the check for invoice report here so the iouReport can be updated correctly in optimistic data.

} else if ((ReportUtils.isExpenseReport(iouReport) || ReportUtils.isInvoiceReport(iouReport)) && typeof iouReport.total === 'number') {

App/src/libs/actions/IOU.ts

Line 2388 in 0e8a10d

    
           } else if (ReportUtils.isExpenseReport(iouReport) && typeof iouReport.total === 'number') {

What alternative solutions did you explore? (Optional)

If the invoice report should be updated in IOUUtils.updateIOUOwnerAndTotal, we should change this condition accordingly for this report like this

if ((iouReportUpdate.total) * (ReportUtils.isInvoiceReport(iouReport) ? -1 : 1) < 0) {

App/src/libs/IOUUtils.ts

Lines 88 to 92 in 0e8a10d

    
           if (iouReportUpdate.total < 0) { 
        
               // The total sign has changed and hence we need to flip the manager and owner of the report. 
        
               iouReportUpdate.ownerAccountID = iouReport.managerID; 
        
               iouReportUpdate.managerID = iouReport.ownerAccountID; 
        
               iouReportUpdate.total = -iouReportUpdate.total;

@strepanier03

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

Working on testing this, haven't been able to repro so far but will keep working on it.

@strepanier03

@strepanier03 Eep! 4 days overdue now. Issues have feelings too...

I am only able to test via Browserstack and I'm still struggling to recreate this. I added testing labels so we can get some weekly testing done before moving forward.

@strepanier03

@strepanier03 Still overdue 6 days?! Let's take care of this!

@strepanier03

@strepanier03 10 days overdue. Is anyone even seeing these? Hello?

Pausing during retesting, no repro for 1 week. Holding.

Pausing during retesting. I'm unable to repro still.

@strepanier03

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Retesting.

I'm not able to repro this still. Closing now.

Navigation Menu

Repository navigation

[Re-test] Workspace - "Hmm it's not here" message appears briefly when changing tags #41905

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

8 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (iouReportUpdate.total < 0) {
	// The total sign has changed and hence we need to flip the manager and owner of the report.
	iouReportUpdate.ownerAccountID = iouReport.managerID;
	iouReportUpdate.managerID = iouReport.ownerAccountID;
	iouReportUpdate.total = -iouReportUpdate.total;

	if (isInvoiceReport(moneyRequestReport) && isManager) {
	return false;
	}

[Re-test] Workspace - "Hmm it's not here" message appears briefly when changing tags #41905

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 9, 2024

lanitochka17 commented on May 9, 2024

nkdengineer commented on May 10, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 14, 2024

strepanier03 commented on May 16, 2024

melvin-bot commented on May 21, 2024

strepanier03 commented on May 21, 2024

8 remaining items

melvin-bot commented on Jun 6, 2024

melvin-bot commented on Jun 10, 2024

strepanier03 commented on Jun 10, 2024

strepanier03 commented on Jun 13, 2024

melvin-bot commented on Jun 17, 2024

strepanier03 commented on Jun 18, 2024

strepanier03 commented on Jun 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions