show category picker in invoices confirmation by gijoe0295 · Pull Request #41723 · Expensify/App

gijoe0295 · 2024-05-07T04:55:52Z

Details

This PR shows category picker when creating invoices.

Fixed Issues

Tests

Note

Tags, Tax rate and Tax amount does not appear in IOU confirmation screen but appear in transaction report. This is a temporary fix until the BE supported those fields when creating invoices.

Press FAB >> Send invoice >> Select any participant and a Collect workspace with categories enabled
Verify in confirmation screen, the Category menu shows and you can select a category
If the workspace required user provided the merchant, verify Required appears in the Merchant field
Press Send invoice
Open transaction report
Verify you can change the category
Verify you can change the tags and tax, if any
=====
Create a new account
Click on FAB > Submit Expense
Enter the email and select participant
Verify app does not crash

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Note

Tags, Tax rate and Tax amount does not appear in IOU confirmation screen but appear in transaction report. This is a temporary fix until the BE supported those fields when creating invoices.

Press FAB >> Send invoice >> Select any participant and a Collect workspace with categories enabled
Verify in confirmation screen, the Category menu shows and you can select a category
If the workspace required user provided the merchant, verify Required appears in the Merchant field
Press Send invoice
Open transaction report
Verify you can change the category
Verify you can change the tags and tax, if any
=====
Create a new account
Click on FAB > Submit Expense
Enter the email and select participant
Verify app does not crash

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

video_2024-05-03_17-37-08.mp4

Android: mWeb Chrome

video_2024-05-03_19-31-42.mp4

iOS: Native

Screen.Recording.2024-05-03.at.17.28.12-source.mov

iOS: mWeb Safari

Screen.Recording.2024-05-03.at.17.03.14-source.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-03.at.19.29.28-source.mov

Screen.Recording.2024-05-07.at.12.05.37-source.mov

MacOS: Desktop

Screen.Recording.2024-05-03.at.16.30.07-source.mov

melvin-bot · 2024-05-07T05:02:46Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2024-05-07T08:47:06Z

@gijoe0295 @cristipaval Are you facing the issue on dev main branch where the sent invoice disappears and OpenReport API calls repetitively? Due to that, I am struggling to test this PR properly.

Screen.Recording.2024-05-07.at.14.11.44.mov

gijoe0295 · 2024-05-07T09:31:38Z

@Pujan92 Yes I got it as well, the messages jumped in chaos, it moved to the top of the screen.

When you switched to another report and back, it would work properly.

Pujan92 · 2024-05-07T12:00:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

mn2.webm

Android: mWeb Chrome

ma1.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-04.at.16.02.18.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-04.at.15.58.52.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-05-04.at.15.48.57.mov

Screen.Recording.2024-05-07.at.14.09.20.mov

MacOS: Desktop

Screen.Recording.2024-05-04.at.16.05.27.mov

Pujan92

LGTM!

OSBotify · 2024-05-07T12:43:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:38:22Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-13T08:21:34Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2024-06-18T00:53:01Z

+    // TODO: remove the !isTypeInvoice from this condition after BE supports tags for invoices: https://github.com/Expensify/App/issues/41281
+    const shouldShowTags = useMemo(() => isPolicyExpenseChat && OptionsListUtils.hasEnabledTags(policyTagLists) && !isTypeInvoice, [isPolicyExpenseChat, policyTagLists, isTypeInvoice]);

    // A flag for showing tax rate
-    const shouldShowTax = isTaxTrackingEnabled(isPolicyExpenseChat, policy);
+    // TODO: remove the !isTypeInvoice from this condition after BE supports tax for invoices: https://github.com/Expensify/App/issues/41281
+    const shouldShowTax = isTaxTrackingEnabled(isPolicyExpenseChat, policy) && !isTypeInvoice;


Is there a tracking issue for the BE implementation?

Not yet. Cc @danielrvidal @cristipaval We agreed earlier #41281 (comment) that we temporarily hide these fields/parameters until BE supports them in the SendInvoice API.

gijoe0295 added 2 commits May 7, 2024 11:49

show category picker in invoices confirmation

7e82fe5

revert redundant changes

5efa8a3

gijoe0295 marked this pull request as ready for review May 7, 2024 05:02

gijoe0295 requested a review from a team as a code owner May 7, 2024 05:02

melvin-bot Bot requested review from Pujan92 and removed request for a team May 7, 2024 05:02

Pujan92 approved these changes May 7, 2024

View reviewed changes

melvin-bot Bot requested a review from cristipaval May 7, 2024 12:03

cristipaval approved these changes May 7, 2024

View reviewed changes

cristipaval merged commit 9cad715 into Expensify:main May 7, 2024

github-actions Bot mentioned this pull request May 9, 2024

Deploy Checklist: New Expensify 2024-05-09 #41874

Closed

37 tasks done

cretadn22 mentioned this pull request May 9, 2024

Split expense - Merchant field is shown as required while making split expense #41886

Closed

2 of 6 tasks

lanitochka17 mentioned this pull request May 9, 2024

[Re-test] Workspace - "Hmm it's not here" message appears briefly when changing tags #41905

Closed

1 of 6 tasks

melvin-bot Bot mentioned this pull request May 13, 2024

[HIGH][$250] Send invoice - Category is missing in confirmation page but it is present in invoice view #41281

Closed

6 tasks done

s77rt reviewed Jun 18, 2024

View reviewed changes

Navigation Menu

Repository navigation

show category picker in invoices confirmation - #41723

show category picker in invoices confirmation#41723
cristipaval merged 2 commits into
Expensify:mainfrom
gijoe0295:gijoe/41281-again

gijoe0295 commented May 7, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented May 7, 2024

Uh oh!

Pujan92 commented May 7, 2024

Uh oh!

gijoe0295 commented May 7, 2024 •

edited

Loading

Uh oh!

Pujan92 commented May 7, 2024 •

edited

Loading

Uh oh!

Pujan92 left a comment

Uh oh!

OSBotify commented May 7, 2024

Uh oh!

OSBotify commented May 9, 2024

Uh oh!

OSBotify commented May 13, 2024

Uh oh!

s77rt Jun 18, 2024

Uh oh!

gijoe0295 Jun 18, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gijoe0295 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 7, 2024

Uh oh!

Pujan92 commented May 7, 2024

Uh oh!

gijoe0295 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pujan92 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 7, 2024

Uh oh!

OSBotify commented May 9, 2024

Uh oh!

OSBotify commented May 13, 2024

Uh oh!

s77rt Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gijoe0295 commented May 7, 2024 •

edited

Loading

gijoe0295 commented May 7, 2024 •

edited

Loading

Pujan92 commented May 7, 2024 •

edited

Loading