[HOLD for payment 2024-06-24] [$250] Desktop app startup is slow

@neil-marcellini

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.75-0
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1716480870229429

Action Performed:

Install the desktop app on Mac
Open it
Quit/close it completely
Open it again

Expected Result:

The app opens quickly, within a few seconds

Actual Result:

The app takes over 30 seconds to open, then a bunch of time to load a chat. Let's focus on the slow opening part specifically, since that's unique to the desktop app.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

desktop-startup720.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0192a06bcd75528339
Upwork Job ID: 1793745864691560448
Last Price Increase: 2024-06-06
Automatic offers:

eh2077 | Reviewer | 102692308
dominictb | Contributor | 102692310

Issue Owner

Current Issue Owner: @anmurali

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Job added to Upwork: https://www.upwork.com/jobs/~0192a06bcd75528339

@eh2077

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

I would like to take on this job

@goldenbear101

📣 @goldenbear101! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@eh2077

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

feat: add universal build for desktop app #43505

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

@eh2077 requires payment automatic offer (Reviewer)
@dominictb requires payment automatic offer (Contributor)

@eh2077

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eh2077] The PR that introduced the bug has been identified. Link to the PR:
[@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eh2077] Determine if we should create a regression test for this bug.
[@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@eh2077

Checklist

[@eh2077] The PR that introduced the bug has been identified. Link to the PR: I don't think there's a specific PR responsible for this
[@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@eh2077] Determine if we should create a regression test for this bug. No

@mallenexpensify

We fixed two issues together here

[HOLD for payment 2024-06-24][$1000] Correct chat is not opening when typing someone's name and hit Enter in chat switcher #39631
[HOLD for payment 2024-06-24] [$250] Desktop app startup is slow #42558

@mallenexpensify I saw you have handled the payment for the other issue. Can you also take care of this one please? As for the payment arrangement, whatever you all think is best works for me!

@anmurali

@anmurali, @neil-marcellini, @eh2077, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dominictb

Contributor: @dominictb paid $250 via Upwork
Contributor+: @eh2077 paid $250 via Upwork

@eh2077 , the PR to fix this that you reviewed also fixed another bug. If you invested additional time on the review, because their was an increase of scope, you might be due additional compensation. Comment if so.

Navigation Menu

Repository navigation

[HOLD for payment 2024-06-24] [$250] Desktop app startup is slow #42558

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

54 remaining items

Checklist

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-06-24] [$250] Desktop app startup is slow #42558

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 23, 2024

MelvinBot commented on May 23, 2024

melvin-bot commented on May 23, 2024

melvin-bot commented on May 23, 2024

goldenbear101 commented on May 24, 2024

melvin-bot commented on May 24, 2024

54 remaining items

melvin-bot commented on Jun 21, 2024

melvin-bot commented on Jun 21, 2024

eh2077 commented on Jun 27, 2024

Checklist

eh2077 commented on Jun 27, 2024

melvin-bot commented on Jun 27, 2024

mallenexpensify commented on Jun 28, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions