Repository navigation
[HOLD for payment 2024-08-14] [$250] MEDIUM: [Debugability] Add profile trace download option to Desktop and Web #43363
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
e.g. memory consumption, storage read/write times, React native bridge concerns, inefficient React component rendering, etc.
Desktop and web performance is currently difficult to evaluate compared with mobile because we don't support profile tracing
What is the impact of this on end-users?
List specific user experiences that will be improved by solving this problem e.g. app boot time, time to for some interaction to complete, etc.
Desktop and web users are unable to have their performance issues fully triaged.
List any benchmarks that show the severity of the issue
Please also provide exact steps taken to collect metrics above if any so we can independently verify the results.
Triaging this issue would benefit from having a profile trace
Proposed solution (if any)
Please list out the steps you think we should take to solve this issue.
Add web support to react-native-release-profiler
Make the "share profile" flow work on web as well
Add profile trace functionality to the desktop and web apps, in the Troubleshoot menu and four-finger-tap menu
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
Note: These should be the same as the benchmarks collected before any changes.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @muttmuure
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~018b1cc2a053306cc3
- Upwork Job ID: 1801178849066862909
- Last Price Increase: 2024-06-20
Issue Owner
Current Issue Owner: @jayeshmangwaniMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Jun 10, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
[-]MEDIUM: [Debugability] Add profile trace download option to Desktop [/-][+][$250] MEDIUM: [Debugability] Add profile trace download option to Desktop [/+]melvin-bot commentedon Jun 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~018b1cc2a053306cc3
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)melvin-bot commentedon Jun 18, 2024
@jayeshmangwani Huh... This is 4 days overdue. Who can take care of this?
jayeshmangwani commentedon Jun 18, 2024
Waiting on proposal, bumped on #expensify-open-source
64 remaining items
jayeshmangwani commentedon Aug 5, 2024
@lschurr Issue is not ready to be paid out yet. The original PR was reverted due to a regression, and a new PR was just merged 3 days ago. Please keep this issue open until the new PR has been in production for 7 days.
lschurr commentedon Aug 5, 2024
Can you link the new PR here @jayeshmangwani?
kirillzyusko commentedon Aug 5, 2024
@lschurr it's a link for new PR #46133 🙌
[-][HOLD for payment 2024-08-02] [HOLD for payment 2024-08-01] [$250] MEDIUM: [Debugability] Add profile trace download option to Desktop and Web[/-][+][$250] MEDIUM: [Debugability] Add profile trace download option to Desktop and Web[/+]muttmuure commentedon Aug 7, 2024
#46929
[-][$250] MEDIUM: [Debugability] Add profile trace download option to Desktop and Web[/-][+][HOLD for payment 2024-08-14] [$250] MEDIUM: [Debugability] Add profile trace download option to Desktop and Web[/+]melvin-bot commentedon Aug 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-14. 🎊
For reference, here are some details about the assignees on this issue:
lschurr commentedon Aug 14, 2024
Payment summary:
Due to the regression, payments are half.
jayeshmangwani commentedon Aug 15, 2024
Requested on ND as per #43363 (comment)
JmillsExpensify commentedon Aug 21, 2024
$125 approved for @jayeshmangwani