Split - Error splitting expense after submitting a distance expense

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42069

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Submit expense > Distance
Submit distance expense to a workspace chat
Go to transaction thread
Go to FAB > Split expense > Manual
Split manual expense with a few users

Expected Result:

A new group chat will be created without issue

Actual Result:

There is error splitting expense after submitting a distance expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6514115_1718473333242.distance-and-split_VXUmZEpF.mp4

View all open jobs on GitHub

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@zanyrenney

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-split

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is error splitting expense after submitting a distance expense

What is the root cause of that problem?

We call OpenReport API in withWritableReportOrNotFound if the reportID doesn't exist in report data. So in the create flow, OpenReport API is called every time we open a step in this flow.

App/src/pages/iou/request/step/withWritableReportOrNotFound.tsx

Line 69 in 1e0831e

ReportActions.openReport(route.params.reportID);

When we navigate to the waypoint page, we pass the reportID param as report?.reportID which will be undefined when we create a new request via FAB, and then OpenReport API is called with reportID is undefined which will store the report data with key report_undefined in Onyx.

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 185 in 1e0831e

    
           ROUTES.MONEY_REQUEST_STEP_WAYPOINT.getRoute(action, CONST.IOU.TYPE.SUBMIT, transactionID, report?.reportID, index.toString(), Navigation.getActiveRouteWithoutParams()),

After that, if we create a split expense via FAB, the problem appears here, existingChatReportID is undefined which leads existingSplitChatReport is not empty because in Onyx we have report data with key report_undefined as mentioned above and then we don't create a new optimistic report which makes the SplitBillAndOpenReport fails.

App/src/libs/actions/IOU.ts

Line 3751 in 1e0831e

    
           let existingSplitChatReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${existingChatReportID}`];

What changes do you think we should make in order to solve the problem?

We should only call the OpenReport API in the edit flow to prevent none exist report can be stored in Onyx in the create flow

!!report?.reportID || !route.params.reportID || !isEditing

App/src/pages/iou/request/step/withWritableReportOrNotFound.tsx

Lines 65 to 72 in 1e0831e

    
               if (!!report?.reportID || !route.params.reportID) { 
        
                   return; 
        
               } 
        
               ReportActions.openReport(route.params.reportID); 
        
               // eslint-disable-next-line react-hooks/exhaustive-deps 
        
           }, []);

We should fallback the reportID param in route here so the reportID of waypoint page will not be undefined when we create a distance request

ROUTES.MONEY_REQUEST_STEP_WAYPOINT.getRoute(action, CONST.IOU.TYPE.SUBMIT, transactionID, report?.reportID ?? reportID, index.toString(), Navigation.getActiveRouteWithoutParams()),

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 185 in 1e0831e

    
           ROUTES.MONEY_REQUEST_STEP_WAYPOINT.getRoute(action, CONST.IOU.TYPE.SUBMIT, transactionID, report?.reportID, index.toString(), Navigation.getActiveRouteWithoutParams()),

To prevent this bug happening in the feature, we should check reportID of existingSplitChatReport is empty or not instead of checking existingSplitChatReport

!existingSplitChatReport?.reportID

App/src/libs/actions/IOU.ts

Line 3756 in 1e0831e

if (!existingSplitChatReport && shouldGetOrCreateOneOneDM) {

existingSplitChatReport?.reportID

App/src/libs/actions/IOU.ts

Line 3761 in 1e0831e

if (existingSplitChatReport) {

What alternative solutions did you explore? (Optional)

maybe related to #40579

It's not related to #40579. The RCA is different.

https://expensify.slack.com/archives/GP2FVSJ7Q/p1718649701046849?thread_ts=1718648773.503349&cid=GP2FVSJ7Q VIP split is on pause, so going to close this for now as it is not a priority right now.

Navigation Menu

Repository navigation

Split - Error splitting expense after submitting a distance expense #43798

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (!!report?.reportID \|\| !route.params.reportID) {
	return;
	}

	ReportActions.openReport(route.params.reportID);

	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, []);

Split - Error splitting expense after submitting a distance expense #43798

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 15, 2024

lanitochka17 commented on Jun 15, 2024

lanitochka17 commented on Jun 15, 2024

truph01 commented on Jun 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tsa321 commented on Jun 17, 2024

truph01 commented on Jun 18, 2024

zanyrenney commented on Jun 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions