Repository navigation
Description
Important Links
Strategy
In order to jump start viral growth, we need to migrate all existing customers to NewDot as soon as possible, so they can reap the rewards of the new app we've been building for several years.
Problem
It's common that one employee incurs an expense that includes others (eg: one person buys lunch for their whole office). There's no way to clearly outline this in NewDot though, so it can easily look like they overspent. This can drive manual back and forth between employee and admin, and cause significant loss of efficiency when compounded across the organization. A less efficient experience adds friction to enticing members to make the switch to NewDot and will slow down reunification.
Solution
Add support for attendee tracking in NewDot. This will make it easy for members to clearly indicate when spend is shared with others, and should reduce back and forth about larger than normal requests. The exact scope is TBD, but my thinking is we can do this by:
- Adding an Attendees row on requests in NewDot.
- Allowing members tap on the row, see a list of all eligible attendees, and select from the list.
- Surfacing selected attendees, and amount per person on request detailed.
Implementation Issues
Frontend:
- [HOLD for payment 2024-11-05] [CRITICAL] [Attendee Tracking] Create AttendeeSelectionPage #47171
- [HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for requests #47172
- [HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests #47173
- [HOLD for payment 2024-11-05] [Attendee Tracking] Submitter does not appear in attendee search results #48695
- [HOLD for payment 2024-11-05] [HOLD FOR PAYMENT OCTOBER 31st][$250] Merge App Attendee tracking feature branch #51335
Backend
- https://github.com/Expensify/Expensify/issues/425201
- https://github.com/Expensify/Expensify/issues/419205
- https://github.com/Expensify/Expensify/issues/419206
- https://github.com/Expensify/Expensify/issues/419218
- [Attendee Tracking] Create 'UpdateMoneyRequestAttendees' command to replace 'EditMoneyRequest' #49326
TODO
Finish the project
- https://github.com/Expensify/Expensify/issues/429056
- [Attendee Tracking] Start using the correct nameValuePairs param for Create/Edit #48692
- Update UpdateMoneyRequestAttendees command to return missing onyx data:
_transactions,_report, andreportNameValuePairs - Within
createUpdateMoneyRequestAttendees, update the users recent attendees and pass back to client - App client should update the param used to pass attendees to backend
- App client should switch to the
transaction.attendeesonyx keys - Unblock feature in client by reversing this commit
Post-launch polish:
- Clear out uses of the now-unused Auth attendee param
- Prevent violation bug by returning OnyxData like done here for other updates
- Add more tests like testRequestMoneyPersistsAttendees for edit case
- [Due for payment 2025-06-11] Attendee tracking feature should be a sub-category of 'Rules' #50802
- Once fully migrated, introduce minimum attendee size of 1:
Request::verifyAttributeSize(request, "attendees", 0, Request::MAX_SIZE_NONCOLUMN);
Tasks
- Post Proposal (full Problem/Solution statement) in
#expensify-open-source - Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
- Paste Proposal in the space above with a link to the Slack thread
- Email
strategy@expensify.comand paste in the Proposal - Fill out the High-level overview of the problem, Timeline, and Terminology sections of the Design Doc
- Email
strategy@expensify.com(continue the same email chain as before) with the link to your Design Doc - Host a pre-design meeting (example) in
#expensify-open-sourceto discuss any necessary details in public before filling out the High-level of proposed solution section. - Fill out the High-level of proposed solution section
- Email
stategy@expensify.comagain with links to the doc and pre-design conversation in Slack - Add the
DesignDocReviewlabel to get the High-level of proposed solution section reviewed - Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
- Confirm that the doc has the minimum necessary number of reviews before proceeding
- Host another pre-design meeting in
#expensify-open-sourceto ask for engineering feedback on the technical solution. - Fill out the Detailed implementation of the solution and related sections.
- Re-add the
DesignDocReviewlabel to this issue - Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
- Confirm that the doc has the minimum necessary number of reviews before proceeding
- Email
strategy@expensify.comone last time to let them know the Design Doc is moving into the implementation phase - Implement the changes
- Add regression tests so that QA can test your feature with every deploy (instructions)
- Send out a follow up email to
strategy@expensify.comonce everything has been implemented and do a Project Wrap-Up retrospective that provides:- Summary of what we accomplished with this project
- What went well?
- What could we have done better?
- What did we learn?
Issue Owner
Current Issue Owner: @JmillsExpensifyMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone

Activity
Julesssss commentedon Jul 2, 2024
After discussion here, I want to make the document changes much clearer before seeking help from SWM.
149 remaining items
JmillsExpensify commentedon May 28, 2025
Who's handling the regression steps for this project?
francoisl commentedon May 28, 2025
@JmillsExpensify I have a WIP issue here, but holding until we finish making Attendee Tracking a feature, so we can also add tests for that.
JmillsExpensify commentedon May 30, 2025
@mananjadhav is going to confirm that #61484 is deployed to production, though ahead of that confirmation, here's the payment summary: $500 to @mananjadhav for PR review and testing.
mananjadhav commentedon May 30, 2025
@JmillsExpensify Based on my findings both the PRs are deployed to production. For #61484, we can the commits in the production branch.
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 173 in 4096084
App/src/libs/TransactionUtils/index.ts
Line 338 in 4096084
@Julesssss @francoisl can you also confirm? so that @JmillsExpensify can update the payment summary?
francoisl commentedon May 31, 2025
Yes, that looks correct to me.
JmillsExpensify commentedon Jun 9, 2025
Payment summary: $500 to @mananjadhav for PR review and testing.
garrettmknight commentedon Jun 13, 2025
$500 approved for @mananjadhav
JmillsExpensify commentedon Jun 25, 2025
I think we're done here though please re-open if something is missed.