Skip to content

[HOLD for payment 2024-11-05] [Attendee Tracking] Submitter does not appear in attendee search results #48695

Closed

Description

@Julesssss

Problem

Submitters do not initially appear in the attendee search results. After deselection they do appear in results.

  • Check out the feature-attendeeTracking branch in App
  • Create a paid workspace
  • Locate the workspace chat, create an expense but do not submit
  • Click 'show more' on the confirmation page
  • Search for the selected user, they do not appear
  • Notice the submitting user is listed when searching
  • Search for the unselected user, they appear

Screenshot 2024-09-06 at 11 20 40 Screenshot 2024-09-06 at 11 20 45

364309737-24832d87-0988-4904-9549-d26ddddc0300.mov

Solution

Resolve. Located during initial testing of this PR

Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. self-assigned this
    on Sep 6, 2024
  2. melvin-bot commented on Sep 6, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 6, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. melvin-bot commented on Sep 6, 2024

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    NewFeatureSomething to build that is a new item.
    on Sep 6, 2024
  6. melvin-bot commented on Sep 6, 2024

    @melvin-bot

    Current assignee @muttmuure is eligible for the Bug assigner, not assigning anyone new.

  7. 18 remaining items

  8. Julesssss commented on Sep 12, 2024

    @Julesssss
    ContributorAuthor

    Ah great, ignore me! For some reason I was imagining that 'Recents' would sit underneath the 'Contacts'

  9. Julesssss commented on Sep 18, 2024

    @Julesssss
    ContributorAuthor

    Merged

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 29, 2024
  11. changed the title [-][Attendee Tracking] Submitter does not appear in attendee search results[/-] [+][HOLD for payment 2024-11-05] [Attendee Tracking] Submitter does not appear in attendee search results[/+] on Oct 29, 2024
  12. melvin-bot commented on Oct 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Oct 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-05. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Oct 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
    • [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
    • [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions