Repository navigation
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I will check within a few hours ! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeANDROID.movAndroid: mWeb ChromeANDROID-WEB.moviOS: NativeIOS.moviOS: mWeb SafariIOS-WEB.movMacOS: Chrome / SafariWEB.movMacOS: DesktopDESKTOP.mov |
|
Looks like a bug But when we select another recents user, everything works as expected 2024-09-12.18.21.31.mov |
|
Plus checked start chat page |
|
Yeah I spotted that too, even wrote a comment about it in the main issue. |
Hmmmm |
|
Actually we have this issue 2024-09-13.15.02.07.mov |
|
But otherwise it works well ! |
|
@zfurtak |
|
I'm not sure if it is a bug, because on this page we enabled putting normal strings into the search bar and we can add this '350' user as attendee 🤔 |
Actually yeah |
|
I didn't get tagged by our bot, but yeah that is expected 🙂 |
|
@zfurtak would you mind merging main once more as it has been a few days? Thanks |
|
@Julesssss done, could you merge it to the feature branch as well? 😊 |
|
@zfurtak
|
|
Damn, it looks like a recent change on main has broken some checks. I'll see if anyone is aware... will check back in later. |
|
I think some of the checks may fail cause the base branch is not compatible with main, could you merge it first @Julesssss? 😃 |
|
Yeah just realised this was due to the conflicts 😅 Pushed the updated branch |
1 similar comment
|
Yeah just realised this was due to the conflicts 😅 Pushed the updated branch |
|
@Julesssss all checks passed I think it's ready to be merged 😃 |



Details
Fixed Issues
$ #48695
PROPOSAL:
Tests
Show moreRecentssectionOffline tests
QA Steps
As above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
web-ios-1.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop-1.mov