Repository navigation
[Hold PR #44907] [$250] Report field - Different system message for report field edit in expense report and LHN #44831
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory around https://expensify.testrail.io/index.php?/tests/view/4695978
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Precondition:
- User has created a Text type report field from Report fields section on ND.
- Go to staging.new.expensify.com
- Go to workspace chat.
- Submit two expenses.
- Click on the text field.
- Enter text and save it.
- Revisit the expense report.
Expected Result:
The system message for report field edit will be consistent in expense report and LHN.
Actual Result:
The system message for report field edit is different in expense report and LHN.
In expense report, it shows "changed Text field from undefined to x."
In LHN, it shows "modified field 'Text field'. New value is 'x' (previously '').
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6533092_1720097340111.20240704_204417.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d8549f82fbcaeb27
- Upwork Job ID: 1808920292412937149
- Last Price Increase: 2024-07-04
Activity
melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @arosiclair (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jul 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
arosiclair commentedon Jul 4, 2024
We can demote this per this thread (report fields are behind a beta).
23 remaining items
melvin-bot commentedon Jul 8, 2024
@arosiclair, @trjExpensify, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-][$250] Report field - Different system message for report field edit in expense report and LHN[/-][+][Hold PR #44907] [$250] Report field - Different system message for report field edit in expense report and LHN[/+]trjExpensify commentedon Jul 8, 2024
Cool, holding this issue. 👍
trjExpensify commentedon Jul 10, 2024
PR we're held on is in review.
melvin-bot commentedon Jul 10, 2024
@arosiclair, @trjExpensify, @ZhenjaHorbach Huh... This is 4 days overdue. Who can take care of this?
arosiclair commentedon Jul 11, 2024
Not overdue
arosiclair commentedon Jul 15, 2024
@trjExpensify should we just close this since it'll get fixed by the other issue?
trjExpensify commentedon Jul 15, 2024
Works for me, the PR for that has been deployed.