[HOLD for payment 2024-11-05] Update Invoices setting screen

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.sidhyk9taftq
Project: [#whatsnext] #billpay (view)

Feature Description

Manual Test Steps

Automated Tests

@madmax330

I think this is just waiting for payment, right @madmax330 ?

Yeah we need to pay the c+ for their review

@madmax330

@madmax330
@danielrvidal

I am working on #48345 and need to remove ROUTES.WORKSPACE_INVOICES

But I see a note:

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 136 in 812fc31

    
           // TODO: Uncomment the following line when the invoices screen is ready - https://github.com/Expensify/App/issues/45175.

Should we remove this comment?

@VickyStash

cc @VickyStash I don't think we want to remove it right?

Yeah, ROUTES.WORKSPACE_INVOICES route will be reused in the future.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Update Invoices setting screen #50565

If no regressions arise, payment will be issued on 2024-11-05. 🎊

@madmax330

@madmax330 Could you please assign me, was C+ on #50565.

@greg-schroeder

Issue is ready for payment but no BZ is assigned. @greg-schroeder you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@fedirjh

Payment Summary

Upwork Job

Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@greg-schroeder)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@fedirjh

Payment summary:

C+: @fedirjh - $250 - You can make a manual request

@madmax330

@madmax330 @greg-schroeder Be sure to fill out the Contact List!

@fedirjh

$250 approved for @fedirjh

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-05] Update Invoices setting screen #45175

Part of the Invoicing payments project

Feature Description

Manual Test Steps

Automated Tests

13 remaining items

Payment Summary

BugZero Checklist (@greg-schroeder)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-05] Update Invoices setting screen #45175

Description

Part of the Invoicing payments project

Feature Description

Manual Test Steps

Automated Tests

Activity

danielrvidal commented on Aug 27, 2024

madmax330 commented on Sep 2, 2024

cretadn22 commented on Sep 6, 2024

madmax330 commented on Sep 6, 2024

VickyStash commented on Sep 6, 2024

melvin-bot commented on Oct 2, 2024

13 remaining items

melvin-bot commented on Oct 29, 2024

melvin-bot commented on Oct 29, 2024

fedirjh commented on Oct 29, 2024

melvin-bot commented on Nov 5, 2024

melvin-bot commented on Nov 5, 2024

Payment Summary

BugZero Checklist (@greg-schroeder)

greg-schroeder commented on Nov 5, 2024

melvin-bot commented on Nov 5, 2024

garrettmknight commented on Dec 10, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions