iOS Invoices - App remains on the same page instead of workspace LHN after enabling Invoices

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Go to workspace settings > More features.
Enable Invoices.

Expected Result:

App will return to workspace LHN and invoices tab will be shown.

Actual Result:

App remains in More features page.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6622009_1727865497512.invoice.mp4

View all open jobs on GitHub

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@arosiclair

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #vip-bills

Proposal

Please re-state the problem that we are trying to solve in this issue.

App remains on the same page instead of workspace LHN after enabling Invoices

What is the root cause of that problem?

Comments disable the navigation after enabling invoices

App/src/libs/actions/Policy/Policy.ts

Lines 3139 to 3142 in 9627f5f

    
           // TODO: Uncomment the following line when the invoices screen is ready - https://github.com/Expensify/App/issues/45175. 
        
           // if (enabled && getIsNarrowLayout()) { 
        
           //     navigateWhenEnableFeature(policyID); 
        
           // }

What changes do you think we should make in order to solve the problem?

We can remove the comments from here

App/src/libs/actions/Policy/Policy.ts

Lines 3139 to 3142 in 9627f5f

    
           // TODO: Uncomment the following line when the invoices screen is ready - https://github.com/Expensify/App/issues/45175. 
        
           // if (enabled && getIsNarrowLayout()) { 
        
           //     navigateWhenEnableFeature(policyID); 
        
           // }

    if (enabled && getIsNarrowLayout()) {
         navigateWhenEnableFeature(policyID);
     }

What alternative solutions did you explore? (Optional)

@madmax330

Reproducible in production?: N/A - new feature, doesn't exist in prod

Uncomment the following line when the invoices screen is ready - #45175.

Looks pretty intentional and not a bug for now. I'm just going to close this out since it looks like we already have a plan for re enabling this. cc @madmax330

Navigation Menu

Repository navigation

iOS Invoices - App remains on the same page instead of workspace LHN after enabling Invoices #50056

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// TODO: Uncomment the following line when the invoices screen is ready - https://github.com/Expensify/App/issues/45175.
	// if (enabled && getIsNarrowLayout()) {
	// navigateWhenEnableFeature(policyID);
	// }

iOS Invoices - App remains on the same page instead of workspace LHN after enabling Invoices #50056

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 2, 2024

melvin-bot commented on Oct 2, 2024

github-actions commented on Oct 2, 2024

IuliiaHerets commented on Oct 2, 2024

Nodebrute commented on Oct 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

arosiclair commented on Oct 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions