Repository navigation
[Performance][MEDIUM] General performance investigation for opening app from customer profile trace #46595
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
We had a customer meeting and they had really bad performance. We recorded multiple profile traces with them.
This issue is about the profile trace for app open.
The collection of issues:
- [Due for payment 2025-04-02] [Performance][Search] Opening search for the first time on a big account is causing the app to hang massively #46590
- [Partially backend issue] [HOLD for payment 2025-01-07] [Performance] Typing in search is very laggy for big accounts #46591
- [Performance] User unable to navigate to chat in search results (slow API call blocks the whole app?) #46593
- [Performance] After clicking on a search result it took 4x OpenReport requests to open the final report #46594
- https://expensify.slack.com/archives/C049HHMV9SM/p1722434442673559
- https://expensify.slack.com/archives/C049HHMV9SM/p1722438425183629
What is the impact of this on end-users?
Slow or completely hanging/blocked app when starting.
List any benchmarks that show the severity of the issue
https://share.firefox.dev/4fgLVcm
Proposed solution (if any)
None yet, I will go through the profile and see what can be optimised, what exactly caused those lags.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
not available yet
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Version Number: v9.0.11-5
Reproducible in staging?: not tested
Reproducible in production?: yes
Email or phone of affected tester (no customers): customer
Logs: See performance file
Notes/Photos/Videos: See attached video
Expensify/Expensify Issue URL: n/a
Issue reported by: @hannojg
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721919928992729
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Jul 31, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
hannojg commentedon Jul 31, 2024
cc @sakluger (feel free to assign me as I (or someone from my team) will work on this ticket!)
sakluger commentedon Aug 5, 2024
Hey @hannojg, any updates on this collection of issues?
hannojg commentedon Aug 6, 2024
Working through the issues one by one, currently working on this one:
I will also find someone from my team to help with these performance issues!
sakluger commentedon Aug 8, 2024
Looks like we are adding some timing performance logging: #46807
sakluger commentedon Aug 12, 2024
I'm going to change this to a Weekly since it's a tracking issue related to four specific performance investigations.
93 remaining items
sakluger commentedon Apr 30, 2025
Good find @Nodonisko! Does it seem like the fast search tree is recreated many times in error, or was that done intentionally?
Please let us know if you find anything else.
sakluger commentedon May 2, 2025
@Nodonisko and @hannojg - heads up that I will be OOO from May 5 - 16. Could you please leave at least one update over the next week or two to avoid having this issue go overdue? Thanks!
Nodonisko commentedon May 4, 2025
Sure thing, I will post updates here.
Nodonisko commentedon May 5, 2025
After some more investigation there seems to be also memory leak in component
SearchAutocompleteListwhen usinggetParticipantsAutocompleteList. But still investigating what's exact reason for that leak.sakluger commentedon May 19, 2025
Hey @Nodonisko, I'm back from OOO. Any additional updates?
Nodonisko commentedon May 20, 2025
@sakluger Hi, I recommend closing this one in favor of #60889. I handed all my finding from this issue to @sosek108 and he is continuing with further investigation.
sakluger commentedon May 28, 2025
Sounds good to me! Closing in favor of #60889.