Skip to content

Search - Remove search label  #4677

Closed
Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to NewDot
  2. Click on the search icon
  3. Type anything in the search box

Expected Result:

When there are no results there should be a message informing the user there are no results found or to search via email format.

Actual Result:

There's a unnecessary label below the text input that shows the same text as the user typed in the search input.

Workaround:

N/A visual issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.85-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @Julesssss https://expensify.slack.com/archives/C01GTK53T8Q/p1629112548387500

This label is redundant, it is only shown when no results are found — and simply duplicates the search query that is shown in the input above…

Activity

  1. MelvinBot commented on Aug 16, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. Santhosh-Sellavel commented on Aug 16, 2021

    @Santhosh-Sellavel
    Collaborator

    Proposal

    Simple returning searchValue is the problem here, if we remove it problem solved.

    Screenshot 2021-08-16 at 11 21 00 PM

    Instead, we could return the appropriate message if needed.

  3. aman-atg commented on Aug 16, 2021

    @aman-atg
    Contributor

    Dupe of #4163

  4. added
    ImprovementItem broken or needs improvement.
    and removed on Aug 16, 2021
  5. Beamanator commented on Aug 17, 2021

    @Beamanator
    Contributor

    As @aman-atg mentioned this was originally reported in #4163 so I think we can close this one and continue investigating there. Also Aman had a nice proposal that I accepted in that issue, so I think we're good to move forward in the other issue

  6. Julesssss commented on Aug 17, 2021

    @Julesssss
    Contributor

    Sounds good @Beamanator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions