Skip to content

[HOLD for payment] "No results found" message is missing when there're no search results for New Chat/New Group/Main Search #4163

Closed

Description

@aman-atg

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to e.cash
  2. Open Main Search / New Chat / New Group
  3. Type random word so that there're no search results

Expected Result:

image

Actual Result:

image

Workaround:

Visual Issue

Platform:

  • [:heavy_check_mark: ] Web
  • [ ✔️ ] iOS
  • [:heavy_check_mark: ] Android
  • [:heavy_check_mark: ] Desktop App
  • [:heavy_check_mark: ] Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 21, 2021
  2. MelvinBot commented on Jul 21, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 21, 2021
  4. aman-atg commented on Jul 21, 2021

    @aman-atg
    ContributorAuthor

    Proposal :

    function getHeaderMessage(hasSelectableOptions, hasUserToInvite, searchValue, maxParticipantsReached = false) {
    if (maxParticipantsReached) {
    return translate(preferredLocale, 'messages.maxParticipantsReached');
    }
    if (searchValue && CONST.REGEX.DIGITS_AND_PLUS.test(searchValue) && !Str.isValidPhone(searchValue)) {
    return translate(preferredLocale, 'messages.noPhoneNumber');
    }
    if (!hasSelectableOptions && !hasUserToInvite) {
    if (/^\d+$/.test(searchValue)) {
    return translate(preferredLocale, 'messages.noPhoneNumber');
    }
    return searchValue;
    }
    return '';
    }

    • We're returning searchValue on line 681 instead of that we can use a different message like:
      • No results found
      • No users found
      • Please enter a valid email address
      • or any other message
  5. MelvinBot commented on Jul 27, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. removed their assignment
    on Jul 27, 2021
  7. Beamanator commented on Jul 27, 2021

    @Beamanator
    Contributor

    Thanks @aman-atg but this is technically working as expected. The search is waiting until you type a valid email address, then it will allow you to start a new chat with the email address you typed. We're working on some improvements in #2936 which should cover this case. When that solution gets merged, please feel free to test and let us know if it looks good or if you think it should change 👍 I'll close this for now.

  8. aman-atg commented on Aug 16, 2021

    @aman-atg
    ContributorAuthor

    @Beamanator
    Maybe we can open this issue now. And close the dupe: #4677

    I'll update the proposal.

  9. 45 remaining items

  10. dylanexpensify commented on Sep 2, 2021

    @dylanexpensify
    Contributor

    Sounds good!

  11. aman-atg commented on Sep 2, 2021

    @aman-atg
    ContributorAuthor

    Hi @Beamanator, Can you please clarify if a bonus will be paid for this issue as it was reported by me?

  12. Beamanator commented on Sep 6, 2021

    @Beamanator
    Contributor

    Good question @aman-atg - as @mallenexpensify posted in #expensify-open-source here:

    This change is in effect as of yesterday and the bonus for independently reporting an issue is only valid from yesterday forward. If there are existing, open, GH issues that you believe you should be compensated for reporting a bug, please comment in the issue.

  13. aman-atg commented on Sep 6, 2021

    @aman-atg
    ContributorAuthor

    Thanks for clarifying.

  14. mallenexpensify commented on Sep 6, 2021

    @mallenexpensify
    Contributor

    Actually... since this issue is still open and because @aman-atg has contributed to the issue, I think they should be paid. @aman-atg can you apply for the job here https://www.upwork.com/jobs/~0186891d4078a90470
    @dylanexpensify when you pay @Santhosh-Sellavel for the job can you also pay @aman-atg $250 for reporting the issue, and confirm with a post in this issue that both have been paid? Thx

  15. arielgreen commented on Sep 7, 2021

    @arielgreen
    Contributor

    @Santhosh-Sellavel this is paid, thanks :)

    @aman-atg once you accept the offer in Upwork, I'll issue the bonus payment.

  16. arielgreen commented on Sep 7, 2021

    @arielgreen
    Contributor

    Paid Aman, closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions