Skip to content

Deploy Checklist: New Expensify 2021-08-17 #4701

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2021-08-17#4701
Assignees
applausebot
Labels
MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@OSBotify
OSBotify
opened on Aug 17, 2021

Release Version: 1.0.86-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. OSBotify
    added
    StagingDeployCash
    on Aug 17, 2021
  2. OSBotify
    assigned
    applausebot
    on Aug 17, 2021

  3. mountiny commented on Aug 17, 2021

    @mountiny
    mountiny
    on Aug 17, 2021
    Contributor

    I have checked of these PRs which were just for testing a webhook functionality for following issue: https://github.com/Expensify/Expensify/issues/173928

  4. isagoico commented on Aug 17, 2021

    @isagoico
    isagoico
    on Aug 17, 2021

    Starting QA 🚀

  5. isagoico
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Aug 17, 2021

  6. isagoico commented on Aug 17, 2021

    @isagoico
    isagoico
    on Aug 17, 2021

    Checked off PRs that were incorrectly added to the checklist:

    1. Fix ExpensiInput autoFocus & tab Focus #4593
    2. Hide Password mismatch incase both the passwords are empty #4607
    3. Check for value before checking length #4613
    4. Clear storage immediately on sign out #4614
    5. Fix: autofill on the BaseExpensiInput #4632
    6. Update state picker component in VBA flow #4633
    7. Changed Personal and Company Address Labels #4636
    8. Change picker value color #4641
    9. [CP Staging] Use props not state in NewPasswordForm #4684

  7. isagoico commented on Aug 17, 2021

    @isagoico
    isagoico
    on Aug 17, 2021

    #4710 not reproducible anymore in 1.0.86-1 🎉 Checking it off

  8. isagoico commented on Aug 18, 2021

    @isagoico
    isagoico
    on Aug 18, 2021

    Checked off #4712 since it's being worked on here #4669

  9. isagoico commented on Aug 18, 2021

    @isagoico
    isagoico
    on Aug 18, 2021

    Checking off several PRs that were added because of the CP bug (Checking them off bc if I removed them they just get re added after another CP)

    1. [No QA] Make a dummy change for a test PR #4568
    2. fix: message alignment #4503
    3. Race fix attempt 2 #4436
    4. add autofocus #4402
    5. Attempt at fixing race #4416
    6. Fix: Infinite loader on login #4397
    7. Fix: Selecting a language does not update in real time #4366
    8. Fix User is able to upload a file larger than 50mb #4358
    9. Update XCode to fix iOS deploy #4339
    10. Update getPullRequestsMergedBetween to run pre-set string command #4336
    11. Patch for PR #4190  #4322
    12. Add offline message to IOU and Split bill and allow currency selection while offline #4019
    13. [CP Staging] Remove duplicate form fields #4117
    14. Modify line height so text does not get cut off in LHN #4143
    15. Make sure we get state/status from the right variable name when we get chat report name #4239
    16. Web - Settings - Dropdown symbol overlaps with text in the box #4243
    17. Fix staging due to undefined Onyx key #4286
    18. Fix broken list components on staging #4300
    19. Fix the text style in about page #4522

  10. isagoico commented on Aug 18, 2021

    @isagoico
    isagoico
    on Aug 18, 2021

    Regression is finished!
    Issues found:

    1. iOS - No space between "New" and "Expensify" for the app name #4739
    2. Blank page displayed when navigating to /bank-account/requestor #4728
    3. Red field outlines are not displayed when entering incorrect information #4730
    4. Android - Left half of the new message badge is unresponsive  #4716
    5. Android/iOS - Code blocks are overflowing the app border #4733
    6. mWeb - Request Money - Search box is not auto focused when changing currency #4711
    7. Blank modal displayed when navigating to enable-payments #4719
    8. Unread message indicator does not disappear after some time has passed #4718
    9. iOS - Chat - High resolution picture won't render properly after zoom #4717
    10. mWeb - Chat - Unable to scroll the chat after tapping on New Message badge #4715
    11. Chat - New Message badge always displays 1 new message even when multiple are received #4712
    12. Profile - User status is always offline #4710

    Comments added in PRs:

    1. Andrew 3313 link context menu #3931 (comment)

    Thanks!

  11. isagoico commented on Aug 20, 2021

    @isagoico
    isagoico
    on Aug 20, 2021

    Summary of the Progress with deploy blockers:

    1. Looks like Red field outlines are not displayed when entering incorrect information #4730 was fixed here Handle errorText in TextInputWithLabel #4741 but it has not been CPd to staging. Should we check it off the list? CC @aldo-expensify @alex-mechler @jasperhuangg @nkuoch
    2. iOS - No space between "New" and "Expensify" for the app name #4739 was not a deploy blocker - Checking off Change Expensify.cash to New Expensify #4408
    3. Blank page displayed when navigating to /bank-account/requestor #4728 was fixed but the PR has not been CPd to staging. Are we good to check it off? CC @joelbettner
    4. Android - Left half of the new message badge is unresponsive  #4716 @parasharrajat has a fix for this, he just needs approval to proceed CC @madmax330 @Beamanator
    5. iOS / Android - Screen will scroll on new messages when they are out of view #4754 is still reproducible CC @bondydaa
    6. Android/iOS - Code blocks are overflowing the app border #4733 is failing PR fix: Inline code block styling #4624 CC @johnmlee101

  12. marcaaron commented on Aug 20, 2021

    @marcaaron
    marcaaron
    on Aug 20, 2021
    Contributor

    I think this issue is a deploy blocker -> #4766
    But I am not sure what's causing it and haven't verified if it happens or not on production.

  13. MelvinBot
    added
    MonthlyKSv2
    on Aug 20, 2021

  14. Beamanator commented on Aug 23, 2021

    @Beamanator
    Beamanator
    on Aug 23, 2021
    Contributor

    @Julesssss and I approved and merged @#4716 - but I forgot to add CP Staging :O - @roryabraham @AndrewGable can one of y'all manually CP this? Didn't see these instructions in this SO

  15. isagoico commented on Aug 23, 2021

    @isagoico
    isagoico
    on Aug 23, 2021

    Checking off several PRs that were added due to the CP issue:

    1. Ping ApplauseLeads when PRs get CPed #4414
    2. Allow users to login with validate code and be redirected to Workspace/Card modal #4519
    3. Add Guides call request flow to workspace card configuration screen #4637
    4. don't show user while searching #4647
    5. Add capatilisation to translation & some margin for the input #4688
    6. Search label removed, added no results found instead #4689
    7. select default/local currency #4691
    8. Increase to 5 seconds #4740
    9. Handle errorText in TextInputWithLabel #4741
    10. Display the /bank-account/requestor page #4742
    11. Bumped expensify-common(Supports nested markdown links) #4750
    12. Update CONTRIBUTING.md #4751

  16. 4 remaining items

  17. roryabraham commented on Aug 23, 2021

    @roryabraham
    roryabraham
    on Aug 23, 2021
    Contributor

    #4774 is being CP'd to staging here

  18. isagoico commented on Aug 24, 2021

    @isagoico
    isagoico
    on Aug 24, 2021

    Update on deploy blockers:

    1. Android - Left half of the new message badge is unresponsive  #4716 - Was a pass 🎉 (Fixed here Fix: marker is not clickable on android #4774)
    2. Red field outlines are not displayed when entering incorrect information #4730 is still considered a deploy blocker (CC @marcaaron @aldo-expensify)
    3. Android/iOS - Code blocks are overflowing the app border #4733 (comment) is still reproducible (left a question for @parasharrajat and @johnmlee101)
    4. Re testing this atm [Network] Messages are sending twice on staging desktop app #4766

    Checked off this issue since it was considered not a deploy blocker #4754

    Checking off this PRs that were added to the list because of the CP issue:

    1. update copy for login #4644
    2. Multiline for ExpensiTextInput #4649
    3. Added tooltips to all Icon buttons #4661
    4. Fix context-menu on native devices #4687
    5. [NO QA] Document why we pass the currentDate but we don't use it #4724
    6. [NO QA] Update the PR template to enforce issue linking formatting #4725
    7. Change UI view for Attachments in Chat #4736
    8. Hide localtime for Expensify Emails (Automated Accounts) #4755
    9. [No QA] Post deploy announcements in slack #4757
    10. [No QA] Performance tracking with flipper-plugin-performance #4760
    11. Added translations for CompanyStep #4765
    12. [No QA] Tag mobile deployers instead of @here in #announce for deploy failures #4767
    13. Fix MarkerBadge Count #4773
    14. call debounce only when it's required #4777
    15. Update height of default buttons to to match the text inputs #4792
    16. New breakpoint for tablet size #4793
    17. Fix: IOU - Final review modal design #4795
    18. Update StagingDeployCash for manual cherry-picks #4798
    19. [No QA] Fix regression on web due to #4760 #4800
    20. Add missing period to preferences page #4806

  19. isagoico commented on Aug 24, 2021

    @isagoico
    isagoico
    on Aug 24, 2021

    Update on missing unchecked PRs:

    1. fix: Inline code block styling #4624 is still failing because of Android/iOS - Code blocks are overflowing the app border #4733 (comment)
    2. Handle VBA errors with red field outlines #4431 is still failing because of Blank page displayed when navigating to /bank-account/requestor #4728 since we can't navigate to the Requestor page. Issue was fixed but it has not been CPd to staging, can we check the PR off? CC @joelbettner
    3. Handle VBA errors with red field outlines #4431 is a pass now with the fix pushed for this issue Red field outlines are not displayed when entering incorrect information #4730 (there's still this issue that it's going to be fixed internally here https://github.com/Expensify/Expensify/issues/174749)
    4. add autofocus & hoverstyle #4662 Checking off this one since mWeb - Request Money - Search box is not auto focused when changing currency #4711 is not a deploy blocker
    5. I think we can check off Update fastlane version #4804 I was able to download the latest build in Android so I guess it's a pass? can @roryabraham @aldo-expensify or @sketchydroide confirm just in case 😬
    6. Checking off Added new marker Badge for Report unread messages #4603 since iOS / Android - Screen will scroll on new messages when they are out of view #4754 was considered not a deploy blocker

  20. TomatoToaster commented on Aug 25, 2021

    @TomatoToaster
    TomatoToaster
    on Aug 25, 2021
    Contributor

    Handle VBA errors with red field outlines #4431 is still failing because of Blank page displayed when navigating to /bank-account/requestor #4728 since we can't navigate to the Requestor page. Issue was fixed but it has not been CPd to staging, can we check the PR off? CC @joelbettner

    I think we can check this off, but it would be better to manually CP that PR (here) since it would also unblock us from testing the VBA flow for N6. Would it be possible to manually CP it @roryabraham @AndrewGable?

  21. roryabraham commented on Aug 25, 2021

    @roryabraham
    roryabraham
    on Aug 25, 2021
    Contributor

    @TomatoToaster Yep, I can CP #4742

  22. roryabraham commented on Aug 25, 2021

    @roryabraham
    roryabraham
    on Aug 25, 2021
    Contributor

    Something went wrong with that CP. Let me try to diagnose

  23. roryabraham commented on Aug 25, 2021

    @roryabraham
    roryabraham
    on Aug 25, 2021
    Contributor

    Oh, nevermind. The error was unrelated. #4742 is being deployed here.

  24. isagoico commented on Aug 25, 2021

    @isagoico
    isagoico
    on Aug 25, 2021

    I'm gonna go ahead and check off #4804 since Android and iOS deploys are working as expected now (@roryabraham @aldo-expensify @sketchydroide please stop me if I'm wrong).

    Only things missing are:

    1. [Network] Messages are sent twice  #4214 (CC @marcaaron, not sure if we can remove the deploy blocker here)
    2. Remove unnecessary style causing bug in android #4807 (comment) (CC @aldo-expensify)

  25. roryabraham commented on Aug 25, 2021

    @roryabraham
    roryabraham
    on Aug 25, 2021
    Contributor

    #4214 is demoted from deploy-blocker to regular-old-bug, and while the fix to #4807 (comment) is currently being CP'd to staging, the issue itself has also been demoted from deploy-blocker to regular-old-bug.

    So I think we are good to run a prod deploy. It will include #4807 (comment)

  26. roryabraham commented on Aug 25, 2021

    @roryabraham
    roryabraham
    on Aug 25, 2021
    Contributor

    :shipit:

  27. roryabraham
    closed this as completedon Aug 25, 2021
  28. OSBotify
    reopened this on Aug 25, 2021

  29. roryabraham commented on Aug 25, 2021

    @roryabraham
    roryabraham
    on Aug 25, 2021
    Contributor

    OSBotify doesn't like me

  30. roryabraham commented on Aug 25, 2021

    @roryabraham
    roryabraham
    on Aug 25, 2021
    Contributor

    :shipit:

  31. roryabraham
    closed this as completedon Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions