Repository navigation
[OldDot Rules Migration] Category Rules #47015
Description
Part of the OldDot Rules Migration project
Main issue: https://github.com/Expensify/Expensify/issues/413886
Feature Description
![2024-08-07_14-40-16]
(https://github.com/user-attachments/assets/dba5b219-9d51-4935-909f-ce17e635bdb0)
High Level Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.dk0p2mr4zxie
Detailed Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.dk0p2mr4zxie
Manual Test Steps
TBD
Automated Tests
TBD
Issue Owner
Current Issue Owner: @WojtekBomanMetadata
Metadata
Type
Projects
- Status
Activity
WojtekBoman commentedon Aug 21, 2024
Hi! I'm going to work on this :)
WojtekBoman commentedon Aug 26, 2024
@Expensify/design
I have one question about the Approver page.
I see we have a similar page in the workflows section and it looks like this:
Can the category and tag approver selection pages be implemented similarly this page?
I'm asking because I don't know if I should display the selected approver at the top of the page and the
Allsection below.WojtekBoman commentedon Aug 27, 2024
@shawnborton @dannymcclain Could you take a look at it when you have some time? #47015 (comment)
shawnborton commentedon Aug 27, 2024
I think the answer is yes, but only after there is an approver selected. Otherwise I assume we start off having no approver selected for those two things, and thus the list would not have anything at the top - it would just be a list of all available options.
Also, let's make sure we take a look at the updated flows for approvers as I think what you are showing is the "old" approval UI, right?
dannymcclain commentedon Aug 27, 2024
Agree.
WojtekBoman commentedon Aug 28, 2024
Yes, when I was writing this question I didn't notice it had been updated :)
WojtekBoman commentedon Aug 28, 2024
@marcaaron
I have a few questions about the category rules :)
policy?.maxExpenseAmountwithpolicy?.outputCurrencyfor the default option, right? Is it appropriate to display$0 * Defaultifpolicy?.maxExpenseAmountis 0.policy?.rules?.expenseRulesandpolicy?.rules?.approvalRuleshave own ids. Should I generate optimistic data manually on the frontend side without ids?10 remaining items
melvin-bot commentedon Sep 11, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 4, 2024
This issue has not been updated in over 15 days. @twisterdotcom, @marcaaron, @WojtekBoman, @dukenv0307 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
twisterdotcom commentedon Oct 7, 2024
How is this going? Is it done? This seems old.
marcaaron commentedon Oct 8, 2024
This has been done for a while. But @dukenv0307 needs to be paid for the C+ role?
dukenv0307 commentedon Oct 8, 2024
@twisterdotcom I think we need to process payment. I reviewed this PR so long ago
twisterdotcom commentedon Oct 9, 2024
Payment Summary:
dukenv0307 commentedon Oct 14, 2024
Thank you @twisterdotcom I accepted the offer
sobitneupane commentedon May 15, 2026
The description hint was previously only visible when
Require descriptionwas enabled. In this issue, it was decided that the description hint should be visible regardless of whether the description is required or not.