Invoice - Send invoice option is present when the workspace has not enabled Invoices feature

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating #46567
Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: New Feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Delete all workspaces if there is any workspace.
Create a new workspace.
Go to Workspace settings > More features.
Note that Invoices feature is not enabled.
Go to FAB.

Expected Result:

Send invoice option will not show up if the workspace has not enabled Invoices feature.

Actual Result:

Send invoice option is present when the workspace has not enabled Invoices feature.
The option is also present in invoice room when the workspace has not enabled Invoices feature.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6565089_1723074934706.20240808_075207.mp4

View all open jobs on GitHub

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MonilBhavsar

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Edited by proposal-police: This proposal was edited at 2024-08-08 03:40:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice option is present when the workspace has not enabled Invoices feature.
The option is also present in invoice room when the workspace has not enabled Invoices feature.

What is the root cause of that problem?

In:

App/src/libs/ReportUtils.ts

Line 6157 in 53eee53

if (isPolicyAdmin(report?.policyID ?? '-1', allPolicies)) {

we don't check the policy.invoicingEnabled

What changes do you think we should make in order to solve the problem?

We can uncomment these lines:

App/src/libs/ReportUtils.ts

Line 6156 in 53eee53

    
           // if (PolicyUtils.canSendInvoiceFromWorkspace(policy?.id) && isPolicyAdmin(report?.policyID ?? '-1', allPolicies)) {

App/src/libs/PolicyUtils.ts

Line 511 in 53eee53

    
           // return getActiveAdminWorkspaces(policies).some((policy) => canSendInvoiceFromWorkspace(policy.id));

App/src/pages/iou/request/step/IOURequestStepSendFrom.tsx

Line 46 in 53eee53

// .filter((policy) => PolicyUtils.canSendInvoiceFromWorkspace(policy.id));

App/src/libs/OptionsListUtils.ts

Line 1984 in 53eee53

// && PolicyUtils.canSendInvoiceFromWorkspace(reportOption.policyID);

What alternative solutions did you explore? (Optional)

Proposal updated

@madmax330

It is expected behavior for now. Please read this - #46567 (comment).

cc @madmax330

@rezkiy37

Okay, thanks for clarifying @rezkiy37! Do we have another issue to clean that up or should I assign you to this issue?

@rezkiy37

Okay, thanks for clarifying @rezkiy37! Do we have another issue to clean that up or should I assign you to this issue?

Seems like we don't have an issue to clean up. Can we create it and add it to the proper project and #45182, @madmax330?

I think we should be able to use this, if we don't have any and link it to the tracking

I want to close this issue. Let me create a clean-up issue tomorrow 🙂

@madmax330

cc @madmax330 ^

@MonilBhavsar

I've created #47302.

cc @MonilBhavsar @madmax330

Thanks! Closing this out then

Navigation Menu

Repository navigation

Invoice - Send invoice option is present when the workspace has not enabled Invoices feature #47023

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal updated

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Invoice - Send invoice option is present when the workspace has not enabled Invoices feature #47023

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 8, 2024

melvin-bot commented on Aug 8, 2024

github-actions commented on Aug 8, 2024

dominictb commented on Aug 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dominictb commented on Aug 8, 2024

Proposal updated

rezkiy37 commented on Aug 8, 2024

MonilBhavsar commented on Aug 8, 2024

rezkiy37 commented on Aug 8, 2024

MonilBhavsar commented on Aug 12, 2024

rezkiy37 commented on Aug 12, 2024

MonilBhavsar commented on Aug 13, 2024

rezkiy37 commented on Aug 13, 2024

MonilBhavsar commented on Aug 13, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions